fix(core): avoid breaking change with apps using rxjs 6.x #58341
Conversation
The `rxResource` was using `firstValueFrom` which isn't supported in rxjs 6.x. `@angular/core` currently supports rxjs 6 so we need this to be backwards compatible. This came up when trying to deploy the Material docs site which is still on rxjs 6 ([see](https://github.com/angular/components/actions/runs/11487971079/job/31973721563)).
|
As v19 is a major release and breaking changes are allowed, it would be better to drop the RxJS v6 support. |
|
I generally agree about dropping rxjs 6, but from what I remember, we have kept it because the new error behavior in 7 was hugely breaking for a lot of users (internal ones included). Furthermore, since yesterday's release the breaking change window is closed. |
| .subscribe({ | ||
| next: resolve, | ||
| error: reject, | ||
| complete: () => reject(new Error('Resource completed before producing a value')), |
There was a problem hiding this comment.
Note: rxjs raises an EmptyError here.
|
This PR was merged into the repository by commit c7342be. The changes were merged into the following branches: main, 19.0.x |
The `rxResource` was using `firstValueFrom` which isn't supported in rxjs 6.x. `@angular/core` currently supports rxjs 6 so we need this to be backwards compatible. This came up when trying to deploy the Material docs site which is still on rxjs 6 ([see](https://github.com/angular/components/actions/runs/11487971079/job/31973721563)). PR Close #58341
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The
rxResourcewas usingfirstValueFromwhich isn't supported in rxjs 6.x.@angular/corecurrently supports rxjs 6 so we need this to be backwards compatible. This came up when trying to deploy the Material docs site which is still on rxjs 6 (see).