Skip to content

feat(core): Add incremental hydration public api #58249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thePunderWoman wants to merge 1 commit into from
Closed

feat(core): Add incremental hydration public api #58249

thePunderWoman wants to merge 1 commit into from

Conversation

@thePunderWoman
Copy link
Contributor

@thePunderWoman thePunderWoman commented Oct 17, 2024

This exposes the public api to utilize incremental hydration.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Feature

Does this PR introduce a breaking change?

  • Yes
  • No

@thePunderWoman thePunderWoman added state: blocked action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: major This PR is targeted for the next major release labels Oct 17, 2024
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 17, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 17, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 21, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 21, 2024
@ngbot ngbot bot modified the milestone: Backlog Oct 21, 2024
@thePunderWoman thePunderWoman removed state: blocked area: core Issues related to the framework runtime labels Oct 21, 2024
@ngbot ngbot bot removed this from the Backlog milestone Oct 21, 2024
@thePunderWoman thePunderWoman added the area: core Issues related to the framework runtime label Oct 21, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 21, 2024
@thePunderWoman thePunderWoman marked this pull request as ready for review October 21, 2024 19:52
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 21, 2024
@ngbot ngbot bot modified the milestone: Backlog Oct 21, 2024
@thePunderWoman
feat(core): Add incremental hydration public api
138c53b 
This exposes the public api to utilize incremental hydration.
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Oct 21, 2024
@pullapprove pullapprove bot requested a review from AndrewKushnir October 22, 2024 01:44
AndrewKushnir
AndrewKushnir approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

pkozlowski-opensource
pkozlowski-opensource approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api
Reviewed-for: fw-core

@thePunderWoman thePunderWoman added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 22, 2024
@thePunderWoman thePunderWoman removed the request for review from alxhub October 22, 2024 14:53
@thePunderWoman thePunderWoman added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Oct 22, 2024
@thePunderWoman
Copy link
Contributor Author

thePunderWoman commented Oct 22, 2024 •
edited
Loading

Caretaker note: the adev failures are expected. This is ready for merge. This also needs cl/688243660 to land right before you sync this in.

@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Oct 22, 2024

This PR was merged into the repository by commit 69fc5ae.

The changes were merged into the following branches: main

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 22, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 22, 2024
@thePunderWoman thePunderWoman deleted the incremental-feature branch March 6, 2025 20:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pkozlowski-opensource pkozlowski-opensource pkozlowski-opensource approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime detected: feature PR contains a feature commit merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release

Projects

None yet

Milestone

v19 Feature Freeze Candidates

Development

Successfully merging this pull request may close these issues.

3 participants

@thePunderWoman @AndrewKushnir @pkozlowski-opensource