fix(core): clean up event contract once hydration is done #58174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18a0b83 to
d60da23
Compare
d60da23 to
88caa78
Compare
88caa78 to
2c9959d
Compare
2c9959d to
eec9e4a
Compare
eec9e4a to
b141989
Compare
b141989 to
f852f6b
Compare
f852f6b to
1bdfd1d
Compare
Contributor
|
@arturovt I think we should be safe to land this now. Can you rebase and resolve the conflict? |
In this commit, we clean up the event contract once hydration is complete, which removes event listeners registered through the container manager. If we do not clean up the contract, the listeners will remain on the `document.body`. When incremental hydration is enabled, we cannot clean up the event contract immediately; instead, we schedule its cleanup when the app is destroyed. This is because the event contract is required for deferred blocks, of which we are unaware, that need to be hydrated.
1bdfd1d to
32bc96f
Compare
thePunderWoman
pushed a commit
that referenced
this pull request
Nov 12, 2024
In this commit, we clean up the event contract once hydration is complete, which removes event listeners registered through the container manager. If we do not clean up the contract, the listeners will remain on the `document.body`. When incremental hydration is enabled, we cannot clean up the event contract immediately; instead, we schedule its cleanup when the app is destroyed. This is because the event contract is required for deferred blocks, of which we are unaware, that need to be hydrated. PR Close #58174
Contributor
|
This PR was merged into the repository by commit 4df352b. The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we clean up the event contract once hydration is complete, which removes event
listeners registered through the container manager. If we do not clean up the contract, the listeners
will remain on the
document.body. When incremental hydration is enabled, we cannot clean up the eventcontract immediately; instead, we schedule its cleanup when the app is destroyed. This is because the
event contract is required for deferred blocks, of which we are unaware, that need to be hydrated.