fix(compiler): ignore placeholder-only i18n messages #58154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Message which only contain a single placeholder cannot be translated, there is no static text to be translated. Therefore these messages can be skipped and shouldn't be extracted at all. Ideally, Angular would throw an error if a message is only a placeholder, since it should not contain an `i18n` attribute at all. However this would be a breaking change and require a migration which isn't in scope right now. We can explore converting this to a hard error sometime in the future.
AndrewKushnir
approved these changes
Oct 11, 2024
Contributor
There was a problem hiding this comment.
LGTM 👍
Note that this change is not gated on any flag and is currently targeting patch.
If we think that's too risky, I can put it behind a flag or target major.
I think it might be an unexpected change in behavior for a patch release, so we can target a major release instead.
Contributor
Author
|
Updated to |
Contributor
Author
Member
|
This PR was merged into the repository by commit ba43408. The changes were merged into the following branches: main |
Closed
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Oct 16, 2024
Fixes some tests that started failing, because angular#58154 made it so placeholder-only messages are extracted while angular#58176 added some tests that only contain placeholders.
devversion
pushed a commit
that referenced
this pull request
Oct 16, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Message which only contain a single placeholder cannot be translated, there is no static text to be translated. Therefore these messages can be skipped and shouldn't be extracted at all.
Ideally, Angular would throw an error if a message is only a placeholder, since it should not contain an
i18nattribute at all. However this would be a breaking change and require a migration which isn't in scope right now. We can explore converting this to a hard error sometime in the future.Note that this change is not gated on any flag and is currently targeting
patch. I think this is reasonable because placeholder-only messages are useless to extract, but it is an observable behavior change. If we think that's too risky, I can put it behind a flag or targetmajor.