Skip to content

fix(migrations): properly resolve tsconfig paths on windows #58137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
devversion wants to merge 2 commits into from
Closed

fix(migrations): properly resolve tsconfig paths on windows #58137

devversion wants to merge 2 commits into from

Conversation

@devversion
Copy link
Member

@devversion devversion commented Oct 9, 2024

See individual commits

@devversion
fix(migrations): properly resolve tsconfig paths on windows
8f7d758 
The Angular CLI devkit and Tsurge, as well as TypeScript only deal with
Posix paths. We also normalize paths into posix paths, and try to
implement a devkit compatible virtual file system for the compiler-cli.

This commit fixes an issue where we accidentally resolved `/` to the
system root on Windows. e.g. `C:/`. This broke the posix and devkit
paths throughout tsconfig parsing.

This commit fixes this.

Fixes angular#58132.
@devversion
refactor(migrations): improve statistic tracking of signal input migr…
2527d4f 
…ation

We should skip tracking information for inputs outside migration scope.
@devversion devversion added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Oct 9, 2024
@devversion devversion requested a review from crisbeto October 9, 2024 14:23
@angular-robot angular-robot bot added the area: migrations Issues related to `ng update`/`ng generate` migrations label Oct 9, 2024
@ngbot ngbot bot added this to the Backlog milestone Oct 9, 2024
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 9, 2024
@devversion
Copy link
Member Author

devversion commented Oct 9, 2024

This PR was merged into the repository by commit 2d11314.

The changes were merged into the following branches: main

@devversion devversion closed this in c1aa411 Oct 9, 2024
devversion added a commit that referenced this pull request Oct 9, 2024
@devversion
refactor(migrations): improve statistic tracking of signal input migr…
2d11314 
…ation (#58137)

We should skip tracking information for inputs outside migration scope.

PR Close #58137
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Nov 9, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@devversion @crisbeto