fix(platform-server): destroy PlatformRef when error happens duringthe bootstrap() phase
#58135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @Platonn |
13 tasks
e3fec9e to
c952f39
Compare
Member
|
Tests are failing 😞 |
… the `bootstrap()` phase (angular#58112) The `bootstrap()` phase might fail e.g. due to an rejected promise in some `APP_INIIALIZER`. If `PlatformRef` is not destroyed, then the main app's injector is not destroyed and therefore `ngOnDestroy` hooks of singleton services is not called on the end (failure) of SSR. This could lead to possible memory leaks in custom SSR apps, if their singleton services' `ngOnDestroy` hooks contained an important teardown logic (e.g. unsubscribing from RxJS observable). Note: I needed to fix by the way another thing too: now we destroy `moduleRef` when `platformInjector` is destroyed - by setting a `PLATFORM_DESTROY_LISTENER` Patch port of angular#58112
c952f39 to
cdad299
Compare
devversion
approved these changes
Oct 9, 2024
Member
|
This PR was merged into the repository by commit b40875a. The changes were merged into the following branches: 18.2.x |
devversion
pushed a commit
that referenced
this pull request
Oct 9, 2024
… the `bootstrap()` phase (#58112) (#58135) The `bootstrap()` phase might fail e.g. due to an rejected promise in some `APP_INIIALIZER`. If `PlatformRef` is not destroyed, then the main app's injector is not destroyed and therefore `ngOnDestroy` hooks of singleton services is not called on the end (failure) of SSR. This could lead to possible memory leaks in custom SSR apps, if their singleton services' `ngOnDestroy` hooks contained an important teardown logic (e.g. unsubscribing from RxJS observable). Note: I needed to fix by the way another thing too: now we destroy `moduleRef` when `platformInjector` is destroyed - by setting a `PLATFORM_DESTROY_LISTENER` Patch port of #58112 PR Close #58135
This was referenced Oct 11, 2024
Open
Open
Open
This was referenced Nov 1, 2024
Open
This was referenced Nov 1, 2024
This was referenced Nov 1, 2024
This was referenced Nov 5, 2024
Closed
This was referenced Nov 5, 2024
This was referenced Nov 6, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bootstrap()phase might fail e.g. due to an rejected promise in someAPP_INIIALIZER. IfPlatformRefis not destroyed, then the main app's injector is not destroyed and thereforengOnDestroyhooks of singleton services is not called on the end (failure) of SSR.This could lead to possible memory leaks in custom SSR apps, if their singleton services'
ngOnDestroyhooks contained an important teardown logic (e.g. unsubscribing from RxJS observable).Note: I needed to fix by the way another thing too: now we destroy
moduleRefwhenplatformInjectoris destroyed - by setting aPLATFORM_DESTROY_LISTENERPatch port of #58112