fix(core): clean up afterRender after it is executed #58119
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We stop tracking `afterRender` hooks as soon as they execute, but their on destroy callbacks stay registered until either the injector is destroyed or the user calls `destroy` manually. This was leading to memory leaks in the `@defer` triggers based on top of `afterRender` when placed inside long-lived views, because the callback would execute, but its destroy logic was waiting for the view to be destroyed. These changes resolve the issue by destroying the `AfterRenderRef` once it is executed.
crisbeto
commented
Oct 8, 2024
| this.sequences.delete(sequence); | ||
| // Destroy the sequence so its on destroy callbacks can be cleaned up | ||
| // immediately, instead of waiting until the injector is destroyed. | ||
| sequence.destroy(); |
Member
Author
There was a problem hiding this comment.
I was a bit on the fence whether to do it here or afterRun. I did it here, because it seems like the AfterRenderRef isn't intended to have much logic, but to hold the current state.
AndrewKushnir
approved these changes
Oct 8, 2024
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@crisbeto thanks for the fix 👍
Contributor
|
This PR was merged into the repository by commit 67db430. The changes were merged into the following branches: main, 18.2.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 8, 2024
We stop tracking `afterRender` hooks as soon as they execute, but their on destroy callbacks stay registered until either the injector is destroyed or the user calls `destroy` manually. This was leading to memory leaks in the `@defer` triggers based on top of `afterRender` when placed inside long-lived views, because the callback would execute, but its destroy logic was waiting for the view to be destroyed. These changes resolve the issue by destroying the `AfterRenderRef` once it is executed. PR Close #58119
This was referenced Oct 11, 2024
Open
Open
Open
This was referenced Nov 1, 2024
Open
This was referenced Nov 1, 2024
This was referenced Nov 5, 2024
Closed
This was referenced Nov 5, 2024
This was referenced Nov 6, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We stop tracking
afterRenderhooks as soon as they execute, but their on destroy callbacks stay registered until either the injector is destroyed or the user callsdestroymanually. This was leading to memory leaks in the@defertriggers based on top ofafterRenderwhen placed inside long-lived views, because the callback would execute, but its destroy logic was waiting for the view to be destroyed.These changes resolve the issue by destroying the
AfterRenderRefonce it is executed.