fix(compiler-cli): defer symbols only used in types #58104
Closed
+141
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we don't defer any symbols that have references outside of the `import` statement and the `imports` array. This is a bit too aggressive, because it's possible that the symbol is only used for types (e.g. `viewChild<SomeCmp>('ref')`) which will be stripped when emitting to JS.
These changes expand the logic so that references inside type nodes aren't considered.
**Note:** one special case is when the symbol used in constructor-based DI (e.g. `constructor(someCmp: SomeCmp)`, because these constructors will be compiled to `directiveInject` calls. We don't need to worry about them, because the compiler introduces an addition `import * as i1 from './some-cmp';` import that it uses to refer to the symbol.
Fixes angular#55991.
crisbeto
commented
Oct 7, 2024
Contributor
|
Thanks for the great fix! |
JoostK
approved these changes
Oct 7, 2024
Contributor
|
This PR was merged into the repository by commit 8d8c03a. The changes were merged into the following branches: main, 18.2.x |
AndrewKushnir
pushed a commit
that referenced
this pull request
Oct 7, 2024
Currently we don't defer any symbols that have references outside of the `import` statement and the `imports` array. This is a bit too aggressive, because it's possible that the symbol is only used for types (e.g. `viewChild<SomeCmp>('ref')`) which will be stripped when emitting to JS.
These changes expand the logic so that references inside type nodes aren't considered.
**Note:** one special case is when the symbol used in constructor-based DI (e.g. `constructor(someCmp: SomeCmp)`, because these constructors will be compiled to `directiveInject` calls. We don't need to worry about them, because the compiler introduces an addition `import * as i1 from './some-cmp';` import that it uses to refer to the symbol.
Fixes #55991.
PR Close #58104
This was referenced Oct 11, 2024
Open
Open
Open
This was referenced Nov 1, 2024
Open
This was referenced Nov 1, 2024
This was referenced Nov 5, 2024
Closed
This was referenced Nov 5, 2024
This was referenced Nov 6, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we don't defer any symbols that have references outside of the
importstatement and theimportsarray. This is a bit too aggressive, because it's possible that the symbol is only used for types (e.g.viewChild<SomeCmp>('ref')) which will be stripped when emitting to JS.These changes expand the logic so that references inside type nodes aren't considered.
Note: one special case is when the symbol is used in constructor-based DI (e.g.
constructor(someCmp: SomeCmp), because these constructors will be compiled todirectiveInjectcalls. We don't need to worry about them, because the compiler introduces an additionalimport * as i1 from './some-cmp';import that it uses to refer to the symbol.Fixes #55991.