fix(common): prevent warning about oversize image twice#58021
Closed
arturovt wants to merge 1 commit intoangular:mainfrom
Closed
fix(common): prevent warning about oversize image twice#58021arturovt wants to merge 1 commit intoangular:mainfrom
arturovt wants to merge 1 commit intoangular:mainfrom
Conversation
I’ve noticed that there was a loop inside a loop. Since we’re already iterating through `images` using `forEach`, it was running a `for` loop through `images` again. This was probably a mistake made when the functionality was initially added. The test actually verified that `logs.length` is `1`, but in the real environment, it logs twice (which is quite obvious due to the code). I’ve also added the missing file to the Bazel target.
AndrewKushnir
approved these changes
Oct 1, 2024
Contributor
Contributor
|
Caretaker note: the presubmit looks good (only pre-existing failures), this PR is ready for merge. |
Member
|
This PR was merged into the repository by commit b7bd429. The changes were merged into the following branches: main, 18.2.x |
devversion
pushed a commit
that referenced
this pull request
Oct 2, 2024
I’ve noticed that there was a loop inside a loop. Since we’re already iterating through `images` using `forEach`, it was running a `for` loop through `images` again. This was probably a mistake made when the functionality was initially added. The test actually verified that `logs.length` is `1`, but in the real environment, it logs twice (which is quite obvious due to the code). I’ve also added the missing file to the Bazel target. PR Close #58021
This was referenced Oct 25, 2024
Open
This was referenced Oct 27, 2024
This was referenced Nov 1, 2024
Open
This was referenced Nov 1, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I’ve noticed that there was a loop inside a loop. Since we’re already iterating through
imagesusingforEach, it was running aforloop throughimagesagain. This was probably a mistake made when the functionality was initially added. The test actually verified thatlogs.lengthis1, but in the real environment, it logs twice (which is quite obvious due to the code).I’ve also added the missing file to the Bazel target.