Skip to content

fix(migrations): delete constructor if it only has super call #58013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crisbeto wants to merge 1 commit into from
Closed

fix(migrations): delete constructor if it only has super call #58013

crisbeto wants to merge 1 commit into from

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 30, 2024

Adds some logic to the inject migration that will remove constructors that are made up of only a super call after the migration.

@crisbeto
fix(migrations): delete constructor if it only has super call
2b9d6bd 
Adds some logic to the `inject` migration that will remove constructors that are made up of only a `super` call after the migration.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release area: migrations Issues related to `ng update`/`ng generate` migrations labels Sep 30, 2024
@crisbeto crisbeto requested a review from devversion September 30, 2024 07:14
@ngbot ngbot bot modified the milestone: Backlog Sep 30, 2024
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 30, 2024
@alxhub
Copy link
Member

alxhub commented Sep 30, 2024

This PR was merged into the repository by commit ef577b2.

The changes were merged into the following branches: main, 18.2.x

@alxhub alxhub closed this in ef577b2 Sep 30, 2024
alxhub pushed a commit that referenced this pull request Sep 30, 2024
@crisbeto @alxhub
fix(migrations): delete constructor if it only has super call (#58013)
b9d846d 
Adds some logic to the `inject` migration that will remove constructors that are made up of only a `super` call after the migration.

PR Close #58013
@davidjbradshaw davidjbradshaw mentioned this pull request Oct 6, 2024
Merged
This was referenced Oct 25, 2024
Open
Open
This was referenced Oct 25, 2024
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Oct 25, 2024
Closed
Closed
Closed
This was referenced Oct 27, 2024
Open
Open
This was referenced Oct 27, 2024
Open
Open
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Oct 31, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: migrations Issues related to `ng update`/`ng generate` migrations target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @alxhub @devversion