Skip to content

Conversation

@devversion
Copy link
Member

@devversion devversion commented Sep 26, 2024

This commit expands the VSCode integration of the signal input migration
to allow migration of full classes and all their inputs. This enables a
faster workflow than just migrating every member individually.

See individual commits

@devversion devversion added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Sep 26, 2024
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: language-service Issues related to Angular's VS Code language service labels Sep 26, 2024
@ngbot ngbot bot added this to the Backlog milestone Sep 26, 2024
@devversion devversion force-pushed the ls-inputs-whole-class branch from 65eab99 to 847f9ba Compare September 26, 2024 14:50
@devversion devversion force-pushed the ls-inputs-whole-class branch 2 times, most recently from f7387d3 to a8b8e5d Compare September 27, 2024 11:36
…ts in VSCode

This commit expands the VScode integration of the signal input migration
to allow migration of full classes and all their inputs. This enables a
faster workflow than just migrating every member individually.

In addition, we now properly support migrating classes that are
unexported and no actual metadata is available in `ngtsc` (but this is
fine for the migration).
@devversion devversion force-pushed the ls-inputs-whole-class branch from a8b8e5d to 69640a2 Compare September 27, 2024 11:39
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 27, 2024
@alxhub
Copy link
Member

alxhub commented Sep 30, 2024

This PR was merged into the repository by commit 5c4305f.

The changes were merged into the following branches: main

@alxhub alxhub closed this in 5c4305f Sep 30, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants