fix(common): skip checking whether SVGs are oversized #57966
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
reviewed
Sep 26, 2024
8ffb188 to
cc99730
Compare
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@arturovt thanks for the PR, the code looks good 👍 Could you please also add a test to verify the new behavior and avoid regressions?
cc99730 to
6e2ea10
Compare
AndrewKushnir
approved these changes
Sep 27, 2024
Contributor
JeanMeche
approved these changes
Sep 27, 2024
Contributor
|
@arturovt thanks for adding tests 👍 It looks like one of them is failing on CI (see Could you please take a look when you get a chance? |
Prior to this commit, the `ImagePerformanceWarning` class was checking all `img` elements in the DOM to determine whether they were oversized after the DOM loading was complete. We should not check SVGs because they are vector-based and can scale infinitely without losing quality. Closes angular#57941
6e2ea10 to
e1850fd
Compare
AndrewKushnir
approved these changes
Sep 28, 2024
Contributor
|
Caretaker note: presubmit is "green", this PR is ready for merge. |
Member
|
This PR was merged into the repository by commit e8b2d5f. The changes were merged into the following branches: main, 18.2.x |
alxhub
pushed a commit
that referenced
this pull request
Sep 30, 2024
Prior to this commit, the `ImagePerformanceWarning` class was checking all `img` elements in the DOM to determine whether they were oversized after the DOM loading was complete. We should not check SVGs because they are vector-based and can scale infinitely without losing quality. Closes #57941 PR Close #57966
This was referenced Oct 25, 2024
Open
This was referenced Oct 25, 2024
This was referenced Oct 27, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
ImagePerformanceWarningclass was checking allimgelements in the DOM to determine whether they were oversized after the DOM loading was complete. We should not check SVGs because they are vector-based and can scale infinitely without losing quality.Closes #57941