fix(http): cleanup JSONP script listeners once loading completed #57877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes event listeners from the `script` element once loading is complete. If the element is not garbage collected properly, in Firefox, the script element still appears in the memory tree view, captured by `__zone_symbol__loadfalse -> HTMLScriptElement -> GC Roots`. We should always be good citizens and clean up event listeners when we no longer need them, as browser's garbage collectors work differently. Calling `remove()` on the node doesn't guarantee that the node can be collected.
JoostK
approved these changes
Sep 23, 2024
Member
JoostK
left a comment
There was a problem hiding this comment.
I don't think I'm a code owner, but LGTM.
AndrewKushnir
approved these changes
Sep 29, 2024
Contributor
Contributor
|
Caretaker note: presubmit is "green", this PR is ready for merge. |
Member
|
This PR was merged into the repository by commit 22dafa6. The changes were merged into the following branches: main, 18.2.x |
devversion
pushed a commit
that referenced
this pull request
Oct 1, 2024
) This commit removes event listeners from the `script` element once loading is complete. If the element is not garbage collected properly, in Firefox, the script element still appears in the memory tree view, captured by `__zone_symbol__loadfalse -> HTMLScriptElement -> GC Roots`. We should always be good citizens and clean up event listeners when we no longer need them, as browser's garbage collectors work differently. Calling `remove()` on the node doesn't guarantee that the node can be collected. PR Close #57877
This was referenced Oct 25, 2024
Open
This was referenced Oct 25, 2024
This was referenced Oct 27, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes event listeners from the
scriptelement once loading iscomplete. If the element is not garbage collected properly, in Firefox, the script
element still appears in the memory tree view, captured by
__zone_symbol__loadfalse -> HTMLScriptElement -> GC Roots. We should always be goodcitizens and clean up event listeners when we no longer need them, as browser's garbage
collectors work differently. Calling
remove()on the node doesn't guarantee that thenode can be collected.