fix(compiler): produce less noisy errors when parsing control flow #57711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently several parsing errors in the new control flow (e.g. missing `track` expression) produce errors whose span targets the entire block. This can be really noisy in the IDE where the error can span many lines in the template. These changes switch to highlighting just the start of the block.
devversion
approved these changes
Sep 7, 2024
thePunderWoman
pushed a commit
that referenced
this pull request
Sep 9, 2024
…57711) Currently several parsing errors in the new control flow (e.g. missing `track` expression) produce errors whose span targets the entire block. This can be really noisy in the IDE where the error can span many lines in the template. These changes switch to highlighting just the start of the block. PR Close #57711
Contributor
|
This PR was merged into the repository by commit 40ff18f. The changes were merged into the following branches: main, 18.2.x |
This was referenced Sep 15, 2024
This was referenced Oct 3, 2024
This was referenced Oct 3, 2024
This was referenced Oct 3, 2024
This was referenced Oct 3, 2024
Open
This was referenced Oct 3, 2024
This was referenced Oct 3, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently several parsing errors in the new control flow (e.g. missing
trackexpression) produce errors whose span targets the entire block. This can be really noisy in the IDE where the error can span many lines in the template.These changes switch to highlighting just the start of the block.