Output migration pipe to observable#57691
Closed
pkozlowski-opensource wants to merge 3 commits intoangular:mainfrom
Closed
Output migration pipe to observable#57691pkozlowski-opensource wants to merge 3 commits intoangular:mainfrom
pkozlowski-opensource wants to merge 3 commits intoangular:mainfrom
Conversation
This change contains a fix that takes into account comments attached to outputs and preserves / removes those as needed.
3e105b1 to
138eb96
Compare
This change uses the outputToObservable utility function to convert migrated outputs to Observables. This happens only in test files as it is a common practice to use RxJS to listen to events raised by the component under test.
devversion
approved these changes
Sep 9, 2024
packages/core/schematics/migrations/output-migration/output-migration.ts
Outdated
Show resolved
Hide resolved
packages/core/schematics/migrations/output-migration/output-migration.spec.ts
Outdated
Show resolved
Hide resolved
packages/core/schematics/migrations/output-migration/output-replacements.ts
Outdated
Show resolved
Hide resolved
138eb96 to
08f7c7c
Compare
thePunderWoman
pushed a commit
that referenced
this pull request
Sep 9, 2024
This change uses the outputToObservable utility function to convert migrated outputs to Observables. This happens only in test files as it is a common practice to use RxJS to listen to events raised by the component under test. PR Close #57691
Contributor
|
This PR was merged into the repository by commit cbec46a. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only the last commit to be reviewed.