Skip to content

feat(core): migrate ExperimentalPendingTasks to PendingTasks #57533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
atscott wants to merge 1 commit into from
Closed

feat(core): migrate ExperimentalPendingTasks to PendingTasks #57533

atscott wants to merge 1 commit into from

Conversation

@atscott
Copy link
Contributor

@atscott atscott commented Aug 26, 2024

This commit promotes the ExperimentalPendingTasks service from experimental to developer preview and includes a migration schematic for the rename.

BREAKING CHANGE: ExperimentalPendingTasks has been renamed to PendingTasks.

@pullapprove pullapprove bot requested a review from crisbeto August 26, 2024 20:33
@angular-robot angular-robot bot added detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit area: core Issues related to the framework runtime labels Aug 26, 2024
@ngbot ngbot bot added this to the Backlog milestone Aug 26, 2024
@atscott atscott added the target: major This PR is targeted for the next major release label Aug 26, 2024
@atscott atscott force-pushed the pendingTasksDevPreview branch 3 times, most recently from 2ca5b22 to b75cf4d Compare August 26, 2024 23:33
thePunderWoman
thePunderWoman approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

AndrewKushnir
AndrewKushnir approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@atscott atscott force-pushed the pendingTasksDevPreview branch from b75cf4d to 0067ae2 Compare August 27, 2024 21:18
@atscott atscott force-pushed the pendingTasksDevPreview branch 4 times, most recently from 7712c8b to 2bb25b7 Compare September 16, 2024 15:56
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Sep 16, 2024
@atscott atscott force-pushed the pendingTasksDevPreview branch from 2bb25b7 to 5f7fac2 Compare September 16, 2024 18:45
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Sep 16, 2024
@pkozlowski-opensource pkozlowski-opensource added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Sep 19, 2024
@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Sep 19, 2024

@atscott is looks like it will need a rebase after Alex's effect PR landed.

@atscott atscott force-pushed the pendingTasksDevPreview branch from 885b664 to c16bd8b Compare September 19, 2024 16:20
@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 19, 2024
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Sep 19, 2024
@ngbot ngbot bot modified the milestone: Backlog Sep 19, 2024
@atscott atscott force-pushed the pendingTasksDevPreview branch from c16bd8b to f384307 Compare September 19, 2024 16:59
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Sep 19, 2024
@atscott atscott force-pushed the pendingTasksDevPreview branch from f384307 to 5a9f6fa Compare September 20, 2024 15:07
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Sep 20, 2024
@ngbot ngbot bot modified the milestone: Backlog Sep 20, 2024
@atscott
feat(core): migrate ExperimentalPendingTasks to PendingTasks
7d6a5db 
This commit promotes the `ExperimentalPendingTasks` service from
experimental to developer preview and includes a migration schematic for
the rename.

BREAKING CHANGE: `ExperimentalPendingTasks` has been renamed to
`PendingTasks`.
@atscott atscott force-pushed the pendingTasksDevPreview branch from 5a9f6fa to 7d6a5db Compare September 20, 2024 15:43
@angular-robot angular-robot bot added area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Sep 20, 2024
@ngbot ngbot bot modified the milestone: Backlog Sep 20, 2024
@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Sep 20, 2024

This PR was merged into the repository by commit a1f2298.

The changes were merged into the following branches: main

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Oct 21, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@crisbeto crisbeto crisbeto approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@atscott @pkozlowski-opensource @thePunderWoman @crisbeto @AndrewKushnir