fix(router): Do not unnecessarily run matcher twice on route matching #57530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes a small update to the route matching algorithm to avoid running the matcher function of a route twice. fixes angular#57511
Contributor
Author
AndrewKushnir
approved these changes
Aug 27, 2024
Member
|
This PR was merged into the repository by commit 8f63084. The changes were merged into the following branches: main, 18.2.x |
alxhub
pushed a commit
that referenced
this pull request
Aug 27, 2024
This was referenced Sep 15, 2024
This was referenced Sep 23, 2024
This was referenced Sep 24, 2024
This was referenced Sep 24, 2024
This was referenced Sep 24, 2024
Open
This was referenced Sep 25, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes a small update to the route matching algorithm to avoid running the matcher function of a route twice.
fixes #57511