Skip to content

fix(core): handle hydration of components that project content conditionally #57383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AndrewKushnir wants to merge 1 commit into from
Closed

fix(core): handle hydration of components that project content conditionally #57383

AndrewKushnir wants to merge 1 commit into from

Conversation

@AndrewKushnir
Copy link
Contributor

@AndrewKushnir AndrewKushnir commented Aug 14, 2024

This commit fixes an issue when hydration serialization tries to calculate DOM path to a content projection node (<ng-content>), but such nodes do not have DOM representation.

Resolves #56750.

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No

@AndrewKushnir
fix(core): handle hydration of components that project content condit…
f241b50 
…ionally

This commit fixes an issue when hydration serialization tries to calculate DOM path to a content projection node (`<ng-content>`), but such nodes do not have DOM representation.

Resolves angular#56750.
@AndrewKushnir AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release core: hydration labels Aug 14, 2024
@ngbot ngbot bot added this to the Backlog milestone Aug 14, 2024
@AndrewKushnir AndrewKushnir mentioned this pull request Aug 14, 2024
Closed
thePunderWoman
thePunderWoman approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewKushnir
Copy link
Contributor Author

AndrewKushnir commented Aug 14, 2024

Presubmit.

@AndrewKushnir AndrewKushnir added action: presubmit The PR is in need of a google3 presubmit action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: presubmit The PR is in need of a google3 presubmit labels Aug 14, 2024
@dylhunn
Copy link
Contributor

dylhunn commented Aug 15, 2024

This PR was merged into the repository by commit d4449fc.

The changes were merged into the following branches: main, 18.2.x

@dylhunn dylhunn closed this in d4449fc Aug 15, 2024
dylhunn pushed a commit that referenced this pull request Aug 15, 2024
@AndrewKushnir @dylhunn
fix(core): handle hydration of components that project content condit…
286012f 
…ionally (#57383)

This commit fixes an issue when hydration serialization tries to calculate DOM path to a content projection node (`<ng-content>`), but such nodes do not have DOM representation.

Resolves #56750.

PR Close #57383
This was referenced Aug 28, 2024
Open
Open
henry-alakazhang pushed a commit to freelancer/angular that referenced this pull request Aug 30, 2024
@AndrewKushnir @henry-alakazhang
fix(core): handle hydration of components that project content condit…
e9c9b45 
…ionally (angular#57383)

This commit fixes an issue when hydration serialization tries to calculate DOM path to a content projection node (`<ng-content>`), but such nodes do not have DOM representation.

Resolves angular#56750.

PR Close angular#57383
@akanchhaS akanchhaS mentioned this pull request Sep 13, 2024
Open
@bdr0id bdr0id mentioned this pull request Sep 13, 2024
Closed
@V-Paranoiaque V-Paranoiaque mentioned this pull request Sep 13, 2024
Closed
@soelshaikh soelshaikh mentioned this pull request Sep 13, 2024
Open
@kidwen kidwen mentioned this pull request Sep 13, 2024
Closed
@tdittmann tdittmann mentioned this pull request Sep 13, 2024
Closed
@JoSSte JoSSte mentioned this pull request Sep 13, 2024
Closed
@tomwwinter tomwwinter mentioned this pull request Sep 13, 2024
Closed
@akanchhaS akanchhaS mentioned this pull request Sep 14, 2024
Open
@soelshaikh soelshaikh mentioned this pull request Sep 14, 2024
Open
@V-Paranoiaque V-Paranoiaque mentioned this pull request Sep 14, 2024
Closed
@bdr0id bdr0id mentioned this pull request Sep 14, 2024
Closed
@tomwwinter tomwwinter mentioned this pull request Sep 14, 2024
Closed
@JoSSte JoSSte mentioned this pull request Sep 14, 2024
Closed
@tdittmann tdittmann mentioned this pull request Sep 14, 2024
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 15, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime core: hydration target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Projecting projected content through an ng-template causes Cannot read properties of null (reading 'parentElement') during hydration annotation

3 participants

@AndrewKushnir @dylhunn @thePunderWoman