Skip to content

fix(core): Handle stopPropagation and preventDefault within the stubbed methods. #57354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iteriani wants to merge 4 commits into from
Closed

fix(core): Handle stopPropagation and preventDefault within the stubbed methods. #57354

iteriani wants to merge 4 commits into from

Conversation

@iteriani
Copy link
Contributor

@iteriani iteriani commented Aug 12, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label Aug 12, 2024
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Aug 12, 2024
@ngbot ngbot bot added this to the Backlog milestone Aug 12, 2024
@iteriani iteriani force-pushed the global branch 2 times, most recently from 79811d4 to 14f8673 Compare August 12, 2024 21:35
@iteriani iteriani requested review from tbondwilkinson and removed request for devversion and pkozlowski-opensource August 12, 2024 22:09
@iteriani iteriani requested review from thePunderWoman and removed request for devversion and pkozlowski-opensource August 12, 2024 22:10
@iteriani iteriani force-pushed the global branch 2 times, most recently from aa8b194 to d8f986c Compare August 12, 2024 22:28
@iteriani
refactor(core): Call stopPropagation and preventDefault unconditional…
afc392f 
…ly within the patched methods.

This fixes a few tests in g3 and is a bug fix for the event dispatcher. Otherwise, bubbling might
continue.
@iteriani iteriani changed the title refactor(core): Handle stopPropagation and preventDefault if they were spied on in tests. fix(core): Handle stopPropagation and preventDefault within the stubbed methods. Aug 12, 2024
thePunderWoman
thePunderWoman approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iteriani
Copy link
Contributor Author

iteriani commented Aug 13, 2024

TESTED=[TGP]

@iteriani iteriani added the action: merge The PR is ready for merge by the caretaker label Aug 13, 2024
@AndrewKushnir AndrewKushnir added the target: patch This PR is targeted for the next patch release label Aug 13, 2024
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Aug 13, 2024

This PR was merged into the repository by commit 8bea2e3.

The changes were merged into the following branches: main, 18.1.x, 18.2.x

AndrewKushnir pushed a commit that referenced this pull request Aug 13, 2024
@iteriani @AndrewKushnir
fix(core): Account for addEventListener to be passed a Window or Docu…
db65bc2 
…ment. (#57354)

This happened to work for other event listeners since both had a
addEventListener method.

PR Close #57354
AndrewKushnir pushed a commit that referenced this pull request Aug 13, 2024
@iteriani @AndrewKushnir
refactor(core): Call stopPropagation and preventDefault unconditional…
97e5dcb 
…ly within the patched methods. (#57354)

This fixes a few tests in g3 and is a bug fix for the event dispatcher. Otherwise, bubbling might
continue.

PR Close #57354
AndrewKushnir pushed a commit that referenced this pull request Aug 13, 2024
@iteriani @AndrewKushnir
refactor(core): Call stopPropagation and preventDefault unconditional…
8bea2e3 
…ly within the patched methods. (#57354)

This fixes a few tests in g3 and is a bug fix for the event dispatcher. Otherwise, bubbling might
continue.

PR Close #57354
AndrewKushnir pushed a commit that referenced this pull request Aug 13, 2024
@iteriani @AndrewKushnir
fix(core): Account for addEventListener to be passed a Window or Docu…
7accd9d 
…ment. (#57354)

This happened to work for other event listeners since both had a
addEventListener method.

PR Close #57354
AndrewKushnir pushed a commit that referenced this pull request Aug 13, 2024
@iteriani @AndrewKushnir
refactor(core): Call stopPropagation and preventDefault unconditional…
8104fc2 
…ly within the patched methods. (#57354)

This fixes a few tests in g3 and is a bug fix for the event dispatcher. Otherwise, bubbling might
continue.

PR Close #57354
This was referenced Sep 4, 2024
Closed
Closed
@V-Paranoiaque V-Paranoiaque mentioned this pull request Sep 4, 2024
Closed
@alfonsserra alfonsserra mentioned this pull request Sep 5, 2024
Merged
@kidwen kidwen mentioned this pull request Sep 5, 2024
Closed
@ambrose40 ambrose40 mentioned this pull request Sep 5, 2024
Open
@JoSSte JoSSte mentioned this pull request Sep 5, 2024
Closed
@soelshaikh soelshaikh mentioned this pull request Sep 6, 2024
Open
@kidwen kidwen mentioned this pull request Sep 7, 2024
Merged
@akanchhaS akanchhaS mentioned this pull request Sep 9, 2024
Open
@fjaguado fjaguado mentioned this pull request Sep 9, 2024
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 13, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@tbondwilkinson tbondwilkinson tbondwilkinson approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime requires: TGP This PR requires a passing TGP before merging is allowed target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@iteriani @AndrewKushnir @thePunderWoman @tbondwilkinson