fix(migrations): avoid migrating route component in tests #57317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The migration was migrating all files in a project (like most migrations). As there is no gain in migrating components used in test files. Excluding the test files reduces the migration noise.
crisbeto
approved these changes
Aug 15, 2024
Contributor
|
This PR was merged into the repository by commit ac93839. The changes were merged into the following branches: main, 18.2.x |
dylhunn
pushed a commit
that referenced
this pull request
Aug 15, 2024
The migration was migrating all files in a project (like most migrations). As there is no gain in migrating components used in test files. Excluding the test files reduces the migration noise. PR Close #57317
This was referenced Aug 28, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The migration was migrating all files in a project (like most migrations)
What is the new behavior?
As there is no gain in migrating components used in test files. Excluding the test files reduces the migration noise.
Does this PR introduce a breaking change?
Other information