Skip to content

fix(core): Account for addEventListener to be passed a Window or Document #57282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iteriani wants to merge 3 commits into from
Closed

fix(core): Account for addEventListener to be passed a Window or Document #57282

iteriani wants to merge 3 commits into from

Conversation

@iteriani
Copy link
Contributor

@iteriani iteriani commented Aug 6, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • [] Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • [xx] No

Other information

@iteriani iteriani requested a review from thePunderWoman August 6, 2024 21:46
@angular-robot angular-robot bot added the area: core Issues related to the framework runtime label Aug 6, 2024
@ngbot ngbot bot added this to the Backlog milestone Aug 6, 2024
@iteriani iteriani force-pushed the global branch 2 times, most recently from 6988d9d to cb5d425 Compare August 6, 2024 22:24
AndrewKushnir
AndrewKushnir reviewed Aug 6, 2024
View reviewed changes
crisbeto
crisbeto reviewed Aug 7, 2024
View reviewed changes
iteriani added 2 commits August 7, 2024 10:51
@iteriani
fix(core): Account for addEventListener to be passed a Window or Docu…
14d8065 
…ment.

This happened to work for other event listeners since both had a
addEventListener method.
@iteriani
fixup! fix(core): Account for addEventListener to be passed a Window …
9549519 
…or Document.
AndrewKushnir
AndrewKushnir approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AndrewKushnir AndrewKushnir changed the title bugfix(core): Account for addEventListener to be passed a Window or Document fix(core): Account for addEventListener to be passed a Window or Document Aug 7, 2024
@AndrewKushnir AndrewKushnir added the target: patch This PR is targeted for the next patch release label Aug 7, 2024
thePunderWoman
thePunderWoman approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iteriani iteriani added the action: merge The PR is ready for merge by the caretaker label Aug 7, 2024
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Aug 8, 2024

This PR was merged into the repository by commit 3439cc2.

The changes were merged into the following branches: main, 18.1.x, 18.2.x

AndrewKushnir pushed a commit that referenced this pull request Aug 8, 2024
@iteriani @AndrewKushnir
fix(core): Account for addEventListener to be passed a Window or Docu…
e39b22a 
…ment. (#57282)

This happened to work for other event listeners since both had a
addEventListener method.

PR Close #57282
AndrewKushnir pushed a commit that referenced this pull request Aug 8, 2024
@iteriani @AndrewKushnir
fix(core): Account for addEventListener to be passed a Window or Docu…
9af760e 
…ment. (#57282)

This happened to work for other event listeners since both had a
addEventListener method.

PR Close #57282
This was referenced Sep 4, 2024
Closed
Closed
@V-Paranoiaque V-Paranoiaque mentioned this pull request Sep 4, 2024
Closed
@alfonsserra alfonsserra mentioned this pull request Sep 5, 2024
Merged
@kidwen kidwen mentioned this pull request Sep 5, 2024
Closed
@ambrose40 ambrose40 mentioned this pull request Sep 5, 2024
Open
@JoSSte JoSSte mentioned this pull request Sep 5, 2024
Closed
@soelshaikh soelshaikh mentioned this pull request Sep 6, 2024
Open
@kidwen kidwen mentioned this pull request Sep 7, 2024
Merged
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 8, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto left review comments

@thePunderWoman thePunderWoman thePunderWoman approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@iteriani @AndrewKushnir @thePunderWoman @crisbeto