fix(compiler-cli): run JIT transforms on @NgModule classes with jit: true
#57212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostK
approved these changes
Jul 31, 2024
…t: true` This commit is similar to 98ed5b6, and makes use of the preparation work implemented there. Similar to directives and components marked via `jit: true`, we also need to do the same for JIT marked `@NgModule` classes. This is mostly important for downleveling of decorators to support dependency injection of such classes. Inside Google3, migrating from `ts_library` to `ng_module` turns of decorator downleveling, so the `jit: true` for NgModule's is implicitly requesting/reliant on this transform— as expected.
2ccbab4 to
7bd1d10
Compare
Contributor
|
This PR was merged into the repository by commit e11c0c4. The changes were merged into the following branches: main |
This was referenced Aug 28, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is similar to 98ed5b6, and makes use of the preparation work implemented there.
Similar to directives and components marked via
jit: true, we also need to do the same for JIT marked@NgModuleclasses. This is mostly important for downleveling of decorators to support dependency injection of such classes.Inside Google3, migrating from
ts_librarytong_moduleturns of decorator downleveling, so thejit: truefor NgModule's is implicitly requesting/reliant on this transform— as expected.