Skip to content

Conversation

@atscott
Copy link
Contributor

@atscott atscott commented Jul 30, 2024

This commit adds an option to specify the default value for queryParamsHandling in Router.createUrlTree when another option is not specified (or is null|undefined).

resolves #12664

This commit adds an option to specify the default value for
`queryParamsHandling` in `Router.createUrlTree` when another option is
not specified (or is `null|undefined`).

resolves angular#12664
@atscott atscott added the target: minor This PR is targeted for the next minor release label Jul 30, 2024
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: router labels Jul 30, 2024
@atscott atscott added feature Issue that requests a new feature and removed detected: feature PR contains a feature commit labels Jul 30, 2024
@ngbot ngbot bot added this to the Backlog milestone Jul 30, 2024
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

import {InjectionToken} from '@angular/core';

import {OnSameUrlNavigation} from './models';
import {OnSameUrlNavigation, QueryParamsHandling} from './models';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually there's also shipping to go along with the handling... maybe I'm mistaken.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't included in our logistics solution right now. Maybe open a feature request?

@pullapprove pullapprove bot requested a review from alxhub July 30, 2024 20:58
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Jul 31, 2024
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api, fw-router

@atscott atscott force-pushed the defaultQueryParams branch from c7e0a14 to 05d99cc Compare August 1, 2024 19:26
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Aug 1, 2024
@atscott atscott removed request for alxhub and dylhunn August 1, 2024 22:39
@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit 6c76c91.

The changes were merged into the following branches: main

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: router detected: feature PR contains a feature commit feature Issue that requests a new feature target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow router configuration so that preserveQueryParams is true by default

4 participants