-
Notifications
You must be signed in to change notification settings - Fork 27k
feat(router): Add defaultQueryParamsHandling to router configuration #57198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit adds an option to specify the default value for `queryParamsHandling` in `Router.createUrlTree` when another option is not specified (or is `null|undefined`). resolves angular#12664
thePunderWoman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed-for: public-api
| import {InjectionToken} from '@angular/core'; | ||
|
|
||
| import {OnSameUrlNavigation} from './models'; | ||
| import {OnSameUrlNavigation, QueryParamsHandling} from './models'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually there's also shipping to go along with the handling... maybe I'm mistaken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't included in our logistics solution right now. Maybe open a feature request?
AndrewKushnir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: public-api, fw-router
c7e0a14 to
05d99cc
Compare
|
This PR was merged into the repository by commit 6c76c91. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit adds an option to specify the default value for
queryParamsHandlinginRouter.createUrlTreewhen another option is not specified (or isnull|undefined).resolves #12664