feat(core): Add whenStable helper on ApplicationRef #57190
Conversation
dece8eb to
3101719
Compare
6caf1b2 to
b4b23b1
Compare
There was a problem hiding this comment.
@atscott Is this still required? because it has not reference now
There was a problem hiding this comment.
Nit: I'd love to have some more guidance/explanation here what "stable" means, but I also see that this is maybe not the best spot to document this.
There was a problem hiding this comment.
Should we have a doc page on the concept of stability ?
Currently the "best" one we have on this is https://angular.dev/errors/NG0506
There was a problem hiding this comment.
Yeah, I'm thinking of either some early notes here; or a good page we can link here in the JSDoc
There was a problem hiding this comment.
The documentation on this one is simply a mirror of the one on isStable. I agree, both need improvement, but something that can be done in a follow-up
There was a problem hiding this comment.
yeah, can be a follow-up. definitely wasn't meant to be blocking
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: public-api
Reviewed-for: fw-core
thePunderWoman
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
This commit adds a `whenStable` function to `ApplicationRef` to cover the most common use-case for the `isStable` observable.
|
This PR was merged into the repository by commit 7919982. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit adds a
whenStablefunction toApplicationRefto cover the most common use-case for theisStableobservable.