Skip to content

fix(core): hydration error in some let declaration setups #57173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
crisbeto wants to merge 1 commit into from
Closed

fix(core): hydration error in some let declaration setups #57173

crisbeto wants to merge 1 commit into from

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 29, 2024

Fixes that we were throwing an assertion error during hydration if a @let declaration is used before and immediately inside of a container.

Fixes #57160.

@crisbeto
fix(core): hydration error in some let declaration setups
b108bc2 
Fixes that we were throwing an assertion error during hydration if a `@let` declaration is used before and immediately inside of a container.

Fixes angular#57160.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Jul 29, 2024
@crisbeto crisbeto requested a review from thePunderWoman July 29, 2024 04:49
@ngbot ngbot bot added this to the Backlog milestone Jul 29, 2024
thePunderWoman
thePunderWoman approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@thePunderWoman thePunderWoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 29, 2024
thePunderWoman pushed a commit that referenced this pull request Jul 30, 2024
@crisbeto @thePunderWoman
fix(core): hydration error in some let declaration setups (#57173)
eaa83f9 
Fixes that we were throwing an assertion error during hydration if a `@let` declaration is used before and immediately inside of a container.

Fixes #57160.

PR Close #57173
@thePunderWoman
Copy link
Contributor

thePunderWoman commented Jul 30, 2024

This PR was merged into the repository by commit a752178.

The changes were merged into the following branches: main, 18.1.x

@josuedeleonaguilar josuedeleonaguilar mentioned this pull request Aug 2, 2024
Open
@mayankv87 mayankv87 mentioned this pull request Aug 4, 2024
Open
@jammyjoe jammyjoe mentioned this pull request Aug 22, 2024
Open
@fjaguado fjaguado mentioned this pull request Aug 22, 2024
Closed
This was referenced Aug 22, 2024
Closed
Closed
@rishabh114 rishabh114 mentioned this pull request Aug 22, 2024
Open
@tFaster tFaster mentioned this pull request Aug 22, 2024
Open
@kidwen kidwen mentioned this pull request Aug 22, 2024
Merged
@lakshamanr lakshamanr mentioned this pull request Aug 22, 2024
Closed
@ambrose40 ambrose40 mentioned this pull request Aug 22, 2024
Open
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Aug 30, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thePunderWoman thePunderWoman thePunderWoman approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

[vite] Internal server error: ASSERTION ERROR: Expected [Text|Element|Container|ElementContainer|Projection|IcuContainer] but got LetDeclaration.

2 participants

@crisbeto @thePunderWoman