fix(core): handle shorthand assignment in the inject migration #57134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the migration updates: ```ts constructor(@Inject(LOCALE_ID) locale: string) { console.log({ locale }); } ``` to: ```ts constructor() { console.log({ locale }); } ``` This fixes the migration, and results in: ``` constructor() { const locale = inject(LOCALE_ID); console.log({ locale }); } ```
crisbeto
approved these changes
Jul 25, 2024
Contributor
|
This PR was merged into the repository by commit ca89ef9. The changes were merged into the following branches: main |
vladboisa
pushed a commit
to vladboisa/angular
that referenced
this pull request
Jul 29, 2024
…ar#57134) Currently the migration updates: ```ts constructor(@Inject(LOCALE_ID) locale: string) { console.log({ locale }); } ``` to: ```ts constructor() { console.log({ locale }); } ``` This fixes the migration, and results in: ``` constructor() { const locale = inject(LOCALE_ID); console.log({ locale }); } ``` PR Close angular#57134
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently the migration updates:
to:
What is the new behavior?
This fixes the migration, and results in:
Does this PR introduce a breaking change?
Other information