fix(forms): Make sure statusChanges is emitted#57098
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
fix(forms): Make sure statusChanges is emitted#57098JeanMeche wants to merge 1 commit intoangular:mainfrom
JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
In the cases multiple updates with `emitEvent:false` were requests, `shouldHaveEmitted` wasn't passed correctly and and requests updates were trashed. This commit fixes this. Fixes angular#56999
Contributor
|
@thePunderWoman this looks like a risky change and we'd probably need a TGP for this. Could you please run a TGP when you get a chance? |
Contributor
Contributor
|
Caretaker note: The TGP is green. This is ready to merge. |
Contributor
|
This PR was merged into the repository by commit 81fe053. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the cases multiple updates with
emitEvent:falsewere requests,shouldHaveEmittedwasn't passed correctly and and requests updates were trashed. This commit fixes this.Fixes #56999