feat(core): Add async run method on ExperimentalPendingTasks
#56546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thePunderWoman
approved these changes
Jun 24, 2024
Contributor
thePunderWoman
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
0ae0426 to
3f64297
Compare
3f64297 to
e37fb54
Compare
This helper method is simply a convenience function that reduces some boilerplate with manually adding and removing a task around some asynchronous function.
e37fb54 to
92d9302
Compare
AndrewKushnir
approved these changes
Sep 10, 2024
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Looks great, thanks @atscott 👍
AndrewKushnir
approved these changes
Sep 10, 2024
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
Member
|
This PR was merged into the repository by commit 3ebe6b4. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helper method is simply a convenience function that reduces some boilerplate with manually adding and removing a task around some asynchronous function.