feat(migrations): add migration to convert standalone component route… #56428

eneajaho · 2024-06-13T11:20:56Z

…s to be lazy loaded

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

packages/core/schematics/collection.json

AndrewKushnir · 2024-07-09T05:29:11Z

@eneajaho thanks for creating this draft PR 👍 We'll be happy to look at the code (and help land it), once it's ready for review. Thank you.

eneajaho

Hi @AndrewKushnir
I think this is ready for an initial round of review 🙌

packages/core/schematics/ng-generate/standalone-routes/to-standalone.ts

packages/core/schematics/test/standalone_routes_spec.ts

packages/core/schematics/ng-generate/standalone-routes/index.ts

packages/core/schematics/ng-generate/standalone-routes/to-standalone.ts

AndrewKushnir

@eneajaho thanks for creating this PR 👍 I've left some comments.

I think for this migration, it'd be great to collect references to NgModule-based components that the migration was unable to rewrite and output the list at the end, something like:

🎉 Automated migration has finished! 🎉

Number of updated routes: 53
Number of skipped routes: 156

Note: this migration was unable to optimize the following routes, since they use NgModule-based components:

- `/product/:id` path at `src/app/app.routes.ts`
- `/product/:id/details` path at `src/app/product/details.routes.ts`
...

Consider making those components standalone and run this migration again.

We can also include a link to the standalone migration into the message.

What do you think?

packages/core/schematics/collection.json

packages/core/schematics/ng-generate/standalone-routes/README.md

packages/core/schematics/ng-generate/standalone-routes/to-standalone.ts

packages/core/schematics/ng-generate/route-lazy-loading/to-standalone.ts

AndrewKushnir

@eneajaho thanks for addressing the feedback! I've left a few more comments and it'd be great if @crisbeto can take a look at the changes as well, so I've added him as a reviewer.

packages/core/schematics/ng-generate/route-lazy-loading/README.md

packages/core/schematics/ng-generate/route-lazy-loading/index.ts

packages/core/schematics/ng-generate/route-lazy-loading/to-standalone.ts

packages/core/schematics/ng-generate/route-lazy-loading/util.ts

packages/core/schematics/ng-generate/route-lazy-loading/README.md

packages/core/schematics/ng-generate/route-lazy-loading/index.ts

packages/core/schematics/ng-generate/route-lazy-loading/to-lazy-routes.ts

packages/core/schematics/test/standalone_routes_spec.ts

eneajaho · 2024-07-19T17:55:24Z

@crisbeto This is ready for another round of review. Solved the type issue and removed the ngtsc program.

crisbeto

Sorry for the delay here, it fell off my radar. LGTM, but it needs a rebase.

thePunderWoman · 2024-07-30T16:57:29Z

@eneajaho Looks like this has lint issues. Should be mergeable right after that.

…s to be lazy loaded This schematic helps developers to convert eagerly loaded component routes to lazy loaded routes

eneajaho · 2024-07-30T17:09:08Z

@eneajaho Looks like this has lint issues. Should be mergeable right after that.

Updated. Using feat(migrations) now

thePunderWoman · 2024-07-30T19:59:11Z

Caretaker note: the failing test is unrelated. Safe to merge.

thePunderWoman · 2024-07-30T20:00:42Z

This PR was merged into the repository by commit 147eee4.

The changes were merged into the following branches: main

angular-automatic-lock-bot · 2024-08-30T00:10:40Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

angular-robot bot added the detected: feature PR contains a feature commit label Jun 13, 2024

swami-sanapathi reviewed Jun 14, 2024

View reviewed changes

packages/core/schematics/collection.json Outdated Show resolved Hide resolved

AndrewKushnir self-assigned this Jul 9, 2024

eneajaho mentioned this pull request Jul 10, 2024

New Migration: Route LoadComponent ngxtension/ngxtension-platform#445

Closed

eneajaho force-pushed the feat/migrate-standalone-component-routes-to-lazy branch 2 times, most recently from 4c5e7ca to ae120e5 Compare July 11, 2024 14:09

eneajaho changed the title ~~wip - feat(schematics): add migration to convert standalone component route…~~ feat(schematics): add migration to convert standalone component route… Jul 11, 2024

eneajaho commented Jul 11, 2024

View reviewed changes

packages/core/schematics/ng-generate/standalone-routes/to-standalone.ts Outdated Show resolved Hide resolved

packages/core/schematics/test/standalone_routes_spec.ts Outdated Show resolved Hide resolved

eneajaho marked this pull request as ready for review July 11, 2024 14:17

pullapprove bot requested a review from thePunderWoman July 11, 2024 14:17

JeanMeche reviewed Jul 11, 2024

View reviewed changes

packages/core/schematics/ng-generate/standalone-routes/index.ts Outdated Show resolved Hide resolved

JeanMeche reviewed Jul 11, 2024

View reviewed changes

packages/core/schematics/ng-generate/standalone-routes/to-standalone.ts Outdated Show resolved Hide resolved

AndrewKushnir requested a review from crisbeto July 11, 2024 21:47

AndrewKushnir added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release area: router labels Jul 11, 2024

ngbot bot added this to the Backlog milestone Jul 11, 2024

AndrewKushnir reviewed Jul 11, 2024

View reviewed changes

eneajaho force-pushed the feat/migrate-standalone-component-routes-to-lazy branch from 2c37a9c to ebf0c31 Compare July 12, 2024 08:39

JeanMeche reviewed Jul 12, 2024

View reviewed changes

packages/core/schematics/ng-generate/route-lazy-loading/to-standalone.ts Outdated Show resolved Hide resolved

AndrewKushnir reviewed Jul 12, 2024

View reviewed changes

AndrewKushnir removed their assignment Jul 12, 2024

eneajaho force-pushed the feat/migrate-standalone-component-routes-to-lazy branch from ebf0c31 to 1d81473 Compare July 13, 2024 21:32

evenstensberg reviewed Jul 14, 2024

View reviewed changes

packages/core/schematics/ng-generate/route-lazy-loading/README.md Outdated Show resolved Hide resolved

evenstensberg reviewed Jul 14, 2024

View reviewed changes

packages/core/schematics/ng-generate/route-lazy-loading/index.ts Outdated Show resolved Hide resolved

crisbeto reviewed Jul 15, 2024

View reviewed changes

eneajaho force-pushed the feat/migrate-standalone-component-routes-to-lazy branch 3 times, most recently from 6a46fbe to c1ddacd Compare July 17, 2024 13:57

crisbeto approved these changes Jul 29, 2024

View reviewed changes

eneajaho force-pushed the feat/migrate-standalone-component-routes-to-lazy branch from e74032d to 5167dfa Compare July 29, 2024 17:23

eneajaho requested a review from crisbeto July 29, 2024 17:26

crisbeto approved these changes Jul 29, 2024

View reviewed changes

eneajaho force-pushed the feat/migrate-standalone-component-routes-to-lazy branch from 5167dfa to 3c21c0f Compare July 29, 2024 19:01

JeanMeche removed the request for review from thePunderWoman July 29, 2024 22:07

JeanMeche added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 29, 2024

thePunderWoman added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Jul 30, 2024

feat(migrations): add migration to convert standalone component route…

f71327b

…s to be lazy loaded This schematic helps developers to convert eagerly loaded component routes to lazy loaded routes

eneajaho force-pushed the feat/migrate-standalone-component-routes-to-lazy branch from 3c21c0f to f71327b Compare July 30, 2024 17:08

angular-robot bot added the area: migrations Issues related to `ng update`/`ng generate` migrations label Jul 30, 2024

eneajaho changed the title ~~feat(schematics): add migration to convert standalone component route…~~ feat(migrations): add migration to convert standalone component route… Jul 30, 2024

thePunderWoman approved these changes Jul 30, 2024

View reviewed changes

thePunderWoman closed this in 147eee4 Jul 30, 2024

This was referenced Aug 28, 2024

[Snyk] Upgrade: , , , , , , , jnellissery/angular-ngrx#1

Open

[Snyk] Upgrade: , , , , , , , , jnellissery/Angular-demo-with-best-practices#2

Open

angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 30, 2024

feat(migrations): add migration to convert standalone component route… #56428

feat(migrations): add migration to convert standalone component route… #56428

Uh oh!

Conversation

eneajaho commented Jun 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

Uh oh!

AndrewKushnir commented Jul 9, 2024

Uh oh!

eneajaho left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AndrewKushnir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AndrewKushnir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

eneajaho commented Jul 19, 2024

Uh oh!

crisbeto left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thePunderWoman commented Jul 30, 2024

Uh oh!

eneajaho commented Jul 30, 2024

Uh oh!

thePunderWoman commented Jul 30, 2024

Uh oh!

thePunderWoman commented Jul 30, 2024

Uh oh!

angular-automatic-lock-bot bot commented Aug 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

eneajaho commented Jun 13, 2024 •

edited

Loading

crisbeto left a comment •

edited

Loading