feat(migrations): add migration to convert standalone component route…#56428
Closed
eneajaho wants to merge 1 commit intoangular:mainfrom
Closed
feat(migrations): add migration to convert standalone component route…#56428eneajaho wants to merge 1 commit intoangular:mainfrom
eneajaho wants to merge 1 commit intoangular:mainfrom
Conversation
Contributor
|
@eneajaho thanks for creating this draft PR 👍 We'll be happy to look at the code (and help land it), once it's ready for review. Thank you. |
4c5e7ca to
ae120e5
Compare
eneajaho
commented
Jul 11, 2024
Contributor
Author
eneajaho
left a comment
There was a problem hiding this comment.
Hi @AndrewKushnir
I think this is ready for an initial round of review 🙌
JeanMeche
reviewed
Jul 11, 2024
JeanMeche
reviewed
Jul 11, 2024
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
@eneajaho thanks for creating this PR 👍 I've left some comments.
I think for this migration, it'd be great to collect references to NgModule-based components that the migration was unable to rewrite and output the list at the end, something like:
🎉 Automated migration has finished! 🎉
Number of updated routes: 53
Number of skipped routes: 156
Note: this migration was unable to optimize the following routes, since they use NgModule-based components:
- `/product/:id` path at `src/app/app.routes.ts`
- `/product/:id/details` path at `src/app/product/details.routes.ts`
...
Consider making those components standalone and run this migration again.
We can also include a link to the standalone migration into the message.
What do you think?
2c37a9c to
ebf0c31
Compare
JeanMeche
reviewed
Jul 12, 2024
ebf0c31 to
1d81473
Compare
crisbeto
reviewed
Jul 15, 2024
6a46fbe to
c1ddacd
Compare
0e686be to
e74032d
Compare
Contributor
Author
|
@crisbeto This is ready for another round of review. Solved the type issue and removed the ngtsc program. |
crisbeto
approved these changes
Jul 29, 2024
e74032d to
5167dfa
Compare
crisbeto
approved these changes
Jul 29, 2024
5167dfa to
3c21c0f
Compare
Contributor
|
@eneajaho Looks like this has lint issues. Should be mergeable right after that. |
…s to be lazy loaded This schematic helps developers to convert eagerly loaded component routes to lazy loaded routes
3c21c0f to
f71327b
Compare
Contributor
Author
Updated. Using |
thePunderWoman
approved these changes
Jul 30, 2024
Contributor
|
Caretaker note: the failing test is unrelated. Safe to merge. |
Contributor
|
This PR was merged into the repository by commit 147eee4. The changes were merged into the following branches: main |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s to be lazy loaded
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information