fix(core): handle missing withI18nSupport() call for components that use i18n blocks#56175
Closed
AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): handle missing withI18nSupport() call for components that use i18n blocks#56175AndrewKushnir wants to merge 1 commit intoangular:mainfrom
withI18nSupport() call for components that use i18n blocks#56175AndrewKushnir wants to merge 1 commit intoangular:mainfrom
Conversation
…t use i18n blocks This commit updates hydration serialization logic to handle a case when the `withI18nSupport()` call is not present for an application that has a component that uses i18n blocks. Note: the issue is only reproducible for components that also inject `ViewContainerRef`, since it triggers a special serialization code path. Resolves angular#56074.
This was referenced May 30, 2024
Contributor
Author
thePunderWoman
pushed a commit
that referenced
this pull request
May 30, 2024
…t use i18n blocks (#56175) This commit updates hydration serialization logic to handle a case when the `withI18nSupport()` call is not present for an application that has a component that uses i18n blocks. Note: the issue is only reproducible for components that also inject `ViewContainerRef`, since it triggers a special serialization code path. Resolves #56074. PR Close #56175
Contributor
|
This PR was merged into the repository by commit 31f3975. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates hydration serialization logic to handle a case when the
withI18nSupport()call is not present for an application that has a component that uses i18n blocks. Note: the issue is only reproducible for components that also injectViewContainerRef, since it triggers a special serialization code path.Resolves #56074.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?