fix(core): Do not migrate HttpClientModule imports on components.#56067
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): Do not migrate HttpClientModule imports on components.#56067JeanMeche wants to merge 1 commit intoangular:mainfrom
HttpClientModule imports on components.#56067JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
d6bdc62 to
d0848fe
Compare
Contributor
AndrewKushnir
approved these changes
May 29, 2024
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
LGTM, just one comment to improve the TODO message.
d0848fe to
680b22e
Compare
`provideHttpClient()` returns a `EnvironmentProvider` which is not compatible with component providers.
680b22e to
f4c030b
Compare
crisbeto
approved these changes
May 29, 2024
AndrewKushnir
approved these changes
May 29, 2024
Contributor
|
This PR was merged into the repository by commit 8d75627. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
provideHttpClient()returns aEnvironmentProviderwhich is not compatible with component providers.Also adding a
// TODOto warn aboutHttpClientModulenot being recommended in component imports.