fix(core): signals should be tracked when embeddedViewRef.detectChanges is called#55719
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): signals should be tracked when embeddedViewRef.detectChanges is called#55719atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
525f882 to
9342ac6
Compare
9342ac6 to
1903d99
Compare
alxhub
approved these changes
May 30, 2024
Member
There was a problem hiding this comment.
What do you think about having a debug assertion here that the consumer is a temporary allocated one?
bfe7a55 to
c29b3ef
Compare
…es is called This commit fixes an issue where signals in embedded views are not tracked if they are refreshed with `EmbeddedViewRef.detectChanges` directly. We had previously assumed that embedded views were always refreshed along with their hosts.
c29b3ef to
264393e
Compare
Contributor
|
This PR was merged into the repository by commit 4c7d5d8. The changes were merged into the following branches: main, 18.0.x |
This was referenced Jul 4, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where signals in embedded views are not tracked if they are refreshed with
EmbeddedViewRef.detectChangesdirectly. We had previously assumed that embedded views were always refreshed along with their hosts.