Skip to content

fix(platform-server): remove event dispatch script from HTML when hydration is disabled#55681

Closed
alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4:event-dispatcher-removal
Closed

fix(platform-server): remove event dispatch script from HTML when hydration is disabled#55681
alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4:event-dispatcher-removal

Conversation

@alan-agius4
Copy link
Contributor

Prior to this commit, the included event dispatcher remained in the HTML even when hydration was disabled.

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels May 6, 2024
@alan-agius4 alan-agius4 requested a review from AndrewKushnir May 6, 2024 07:33
@alan-agius4 alan-agius4 added the area: server Issues related to server-side rendering label May 6, 2024
@ngbot ngbot bot added this to the Backlog milestone May 6, 2024
@alan-agius4 alan-agius4 changed the title fix(platform-server): Eliminate event dispatch script from HTML when hydration is disabled fix(platform-server): remove event dispatch script from HTML when hydration is disabled May 6, 2024
@alan-agius4 alan-agius4 force-pushed the event-dispatcher-removal branch from 5c8d9d1 to 6db8fc2 Compare May 6, 2024 07:34
…ration is disabled

Prior to this commit, the included event dispatcher remained in the HTML even when hydration was disabled.
@alan-agius4 alan-agius4 force-pushed the event-dispatcher-removal branch from 6db8fc2 to 5073f98 Compare May 6, 2024 07:35
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alan-agius4 thanks for fixing this issue 👍

@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 6, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit cf84acf.

AndrewKushnir pushed a commit that referenced this pull request May 6, 2024
…ration is disabled (#55681)

Prior to this commit, the included event dispatcher remained in the HTML even when hydration was disabled.

PR Close #55681
@alan-agius4 alan-agius4 deleted the event-dispatcher-removal branch May 6, 2024 19:52
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: server Issues related to server-side rendering target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants