fix(migrations): handle more cases in HttpClientModule migration#55640
Closed
cexbrayat wants to merge 1 commit intoangular:mainfrom
Closed
fix(migrations): handle more cases in HttpClientModule migration#55640cexbrayat wants to merge 1 commit intoangular:mainfrom
cexbrayat wants to merge 1 commit intoangular:mainfrom
Conversation
87ec047 to
e2330d7
Compare
crisbeto
reviewed
May 4, 2024
This commit handles two cases that were breaking applications when using the new migration: - tests using `HttpClientModule` in `TestBed.configureTestingModule` were broken as the import was removed, but the module is still present in the test configuration. It now properly adds `provideHttpClient(withInterceptorsFromDi())` and related imports to the test. - tests using `HttpClientTestingModule` were migrated to use `provideHttpClient(withInterceptorsFromDi())` but the necessary imports were not added. They are now added by the migration.
e2330d7 to
3937b3b
Compare
Member
Author
|
@crisbeto Thank you for the review. I updated the PR with your feedback, PTAL. |
crisbeto
approved these changes
May 6, 2024
Contributor
|
This PR was merged into the repository by commit 7a2efd4. |
AndrewKushnir
pushed a commit
that referenced
this pull request
May 6, 2024
) This commit handles two cases that were breaking applications when using the new migration: - tests using `HttpClientModule` in `TestBed.configureTestingModule` were broken as the import was removed, but the module is still present in the test configuration. It now properly adds `provideHttpClient(withInterceptorsFromDi())` and related imports to the test. - tests using `HttpClientTestingModule` were migrated to use `provideHttpClient(withInterceptorsFromDi())` but the necessary imports were not added. They are now added by the migration. PR Close #55640
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
This commit handles two cases that were breaking applications when using the new migration:
HttpClientModuleinTestBed.configureTestingModulewere broken as the import was removed, but the module is still present in the test configuration.HttpClientTestingModulewere migrated to useprovideHttpClient(withInterceptorsFromDi())but the necessary imports were not added.What is the new behavior?
It now properly adds
provideHttpClient(withInterceptorsFromDi())and related imports to the test for the tests that were usingHttpClientModuleIt also adds the necessary imports for
provideHttpClientandwithInterceptorsFromDifor tests that were usingHttpClientTestingModuleDoes this PR introduce a breaking change?
Other information