fix(core): don't schedule timer triggers on the server#55605
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
fix(core): don't schedule timer triggers on the server#55605crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
Fixes that even though we weren't rendering the deferred block the server, we were still triggering the timeout which can delay the response. Fixes angular#55475.
AndrewKushnir
approved these changes
May 1, 2024
Contributor
|
This PR was merged into the repository by commit a0ec2d8. |
AndrewKushnir
pushed a commit
that referenced
this pull request
May 1, 2024
AndrewKushnir
pushed a commit
that referenced
this pull request
May 1, 2024
This was referenced May 29, 2024
This was referenced May 31, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes that even though we weren't rendering the deferred block the server, we were still triggering the timeout which can delay the response.
Fixes #55475.