fix(compiler): maintain multiline CSS selectors during CSS scoping#55509
Closed
alan-agius4 wants to merge 1 commit intoangular:mainfrom
Closed
fix(compiler): maintain multiline CSS selectors during CSS scoping#55509alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4 wants to merge 1 commit intoangular:mainfrom
Conversation
Contributor
Author
933ade0 to
ee07635
Compare
Previously, multiline selectors were being converted into single lines, resulting in sourcemap disruptions due to shifts in line numbers. Closes angular#55508
crisbeto
approved these changes
May 2, 2024
| return selector | ||
| .split(',') | ||
| .map((part) => part.trim().split(_shadowDeepSelectors)) | ||
| .split(/ ?, ?/) |
Member
There was a problem hiding this comment.
Should we use \s here rather than an actual space?
Contributor
Author
There was a problem hiding this comment.
No otherwise the newlines will get lost which would cause the sourcemaps to break.
Contributor
|
Caretaker note: looks like this PR might have some risk in g3, will proceed with the merge on Monday, 05/06. |
Contributor
|
This PR was merged into the repository by commit 3e1d6e9. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, multiline selectors were being converted into single lines, resulting in sourcemap disruptions due to shifts in line numbers.
Closes #55508