Skip to content

refactor(common): remove deprecated isPlatformWorkerApp and isPlatformWorkerUi API#55302

Closed
alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4:remove-deprecated-platform-worker
Closed

refactor(common): remove deprecated isPlatformWorkerApp and isPlatformWorkerUi API#55302
alan-agius4 wants to merge 1 commit intoangular:mainfrom
alan-agius4:remove-deprecated-platform-worker

Conversation

@alan-agius4
Copy link
Contributor

BREAKING CHANGE: The deprecated isPlatformWorkerUi and isPlatformWorkerApp have been removed without replacement, as they serve no purpose since the removal of the WebWorker platform.

@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Apr 11, 2024
@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Apr 11, 2024
…formWorkerUi` API

BREAKING CHANGE: The deprecated `isPlatformWorkerUi` and `isPlatformWorkerApp` have been removed without replacement, as they serve no purpose since the removal of the WebWorker platform.
@alan-agius4 alan-agius4 force-pushed the remove-deprecated-platform-worker branch from b493eb4 to 010d1a9 Compare April 11, 2024 09:49
@alan-agius4 alan-agius4 marked this pull request as ready for review April 11, 2024 09:49
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 11, 2024
@pullapprove pullapprove bot requested a review from AndrewKushnir April 11, 2024 09:49
@alan-agius4 alan-agius4 requested a review from dylhunn April 11, 2024 12:42
@pkozlowski-opensource pkozlowski-opensource added the area: common Issues related to APIs in the @angular/common package label Apr 11, 2024
@ngbot ngbot bot added this to the Backlog milestone Apr 11, 2024
@pullapprove pullapprove bot requested review from AndrewKushnir and alxhub April 13, 2024 19:15
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from atscott April 13, 2024 19:16
@pullapprove pullapprove bot requested a review from alxhub April 16, 2024 12:34
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 16, 2024
@pkozlowski-opensource
Copy link
Member

This PR was merged into the repository by commit 3b0de30.

@alan-agius4 alan-agius4 deleted the remove-deprecated-platform-worker branch April 17, 2024 06:38
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package detected: breaking change PR contains a commit with a breaking change target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants