fix(core): DeferBlockFixture.render should not wait for stability#55271
Closed
atscott wants to merge 2 commits intoangular:mainfrom
Closed
fix(core): DeferBlockFixture.render should not wait for stability#55271atscott wants to merge 2 commits intoangular:mainfrom
atscott wants to merge 2 commits intoangular:mainfrom
Conversation
bd69858 to
7c979b3
Compare
The `DeferBlockFixture.render` function should not await the `whenStable` promise of the fixture. This does not allow developers to test any intermediate states that might occur between rendering the initial content and the full app stability. fixes angular#55235
AndrewKushnir
approved these changes
Apr 22, 2024
Contributor
|
This PR was merged into the repository by commit c175bca. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DeferBlockFixture.renderfunction should not await thewhenStablepromise of the fixture. This does not allow developers to test any intermediate states that might occur between rendering the initial content and the full app stability. This change updates the wait condition to only wait for one render instead.fixes #55235