Skip to content

feat(core): Add ability to configure zone change detection to use zon…#55252

Closed
atscott wants to merge 1 commit intoangular:mainfrom
atscott:publicZoneOnlyOption
Closed

feat(core): Add ability to configure zone change detection to use zon…#55252
atscott wants to merge 1 commit intoangular:mainfrom
atscott:publicZoneOnlyOption

Conversation

@atscott
Copy link
Contributor

@atscott atscott commented Apr 8, 2024

…eless scheduler

This commit adds a configuration option to zone-based change detection which allows applications to enable/disable the zoneless scheduler. When the zoneless scheduler is enabled in zone-based applications, updates that happen outside the Angular zone will still result in a change detection being scheduled. Previously, Angular change detection was solely based on the state of the Angular Zone.

@atscott atscott added area: core Issues related to the framework runtime area: zones Issues related to zone.js core: change detection target: minor This PR is targeted for the next minor release labels Apr 8, 2024
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 8, 2024
@ngbot ngbot bot modified the milestone: Backlog Apr 8, 2024
@atscott atscott closed this Apr 8, 2024
@atscott atscott force-pushed the publicZoneOnlyOption branch from 7eb5159 to 87cdfaf Compare April 8, 2024 18:51
@angular-robot angular-robot bot removed the detected: feature PR contains a feature commit label Apr 8, 2024
@atscott atscott reopened this Apr 8, 2024
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 8, 2024
@atscott atscott force-pushed the publicZoneOnlyOption branch from eb8913c to 2c419ae Compare April 8, 2024 18:54
@atscott atscott force-pushed the publicZoneOnlyOption branch 3 times, most recently from 4962d74 to 40fd370 Compare April 8, 2024 21:30
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from dylhunn April 9, 2024 19:31
@atscott atscott added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: are those the only / all conditions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s not, no. I’m not sure if/where we should have an exhaustive list. There’s also:

host and template bindings, setting component inputs, and removing dom nodes (but only render hooks run). I guess that’s not too many more. I can add them to the list

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeh, I'm not sure where we should have the full list but would be great to have it in one place and be able to reference it.

Copy link
Member

@pkozlowski-opensource pkozlowski-opensource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed-for: public-api
Reviewed-for: fw-core

…eless scheduler

This commit adds a configuration option to zone-based change detection
which allows applications to enable/disable the zoneless scheduler.
When the zoneless scheduler is enabled in zone-based applications,
updates that happen outside the Angular zone will still result in a
change detection being scheduled. Previously, Angular change detection
was solely based on the state of the Angular Zone.
@atscott atscott force-pushed the publicZoneOnlyOption branch from 40fd370 to 49ef623 Compare April 12, 2024 15:45
@atscott atscott added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Apr 12, 2024
@atscott
Copy link
Contributor Author

atscott commented Apr 12, 2024

caretaker note: syncing to g3 will need this patch: cl/624197677

edit: well, it's actually not needed since it won't break any builds. Those changes could be done in a quick follow-up for those teams

@atscott
Copy link
Contributor Author

atscott commented Apr 12, 2024

This PR was merged into the repository by commit fdd560e.

@atscott atscott closed this in fdd560e Apr 12, 2024
iteriani pushed a commit to iteriani/angular that referenced this pull request Apr 16, 2024
…eless scheduler (angular#55252)

This commit adds a configuration option to zone-based change detection
which allows applications to enable/disable the zoneless scheduler.
When the zoneless scheduler is enabled in zone-based applications,
updates that happen outside the Angular zone will still result in a
change detection being scheduled. Previously, Angular change detection
was solely based on the state of the Angular Zone.

PR Close angular#55252
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: zones Issues related to zone.js core: change detection detected: feature PR contains a feature commit merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants