fix(compiler): remove container index from conditional instruction#55190
Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
Closed
fix(compiler): remove container index from conditional instruction#55190crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
5f678cf to
7948c39
Compare
pkozlowski-opensource
approved these changes
Apr 3, 2024
Member
pkozlowski-opensource
left a comment
There was a problem hiding this comment.
LGTM
Reviewed-for: fw-core
5fc8aa2 to
0b52f47
Compare
Stops passing in the `containerIndex` argument to the `conditional` instruction since it isn't being used anymore.
0b52f47 to
98b7020
Compare
Member
|
This PR was merged into the repository by commit 7d5bc1c. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops passing in the
containerIndexargument to theconditionalinstruction since it isn't being used anymore.