fix(core): do not save point-in-time setTimeout and rAF references#55124
fix(core): do not save point-in-time setTimeout and rAF references#55124atscott wants to merge 1 commit intoangular:mainfrom
setTimeout and rAF references#55124Conversation
ac888c6 to
f98bcec
Compare
Grabbing and saving the references to global `setTimeout` and `rAF` implementations at a certain point in time can be problematic, espcially in tests. Tests might call something like `jasmine.clock().install();` and `jasmine.clock().uninstall();`. If the install happens before we grab the implementation and then the uninstall happens after, our scheduling function will be broken because it would have saved a reference to the jasmine `setTimeout` implementation, which would have since been cleaned up and will throw an error when attempting to access `delayedFunctionScheduler`. There are other scenarios that may apply, not even just for tests, when patches are applied and removed to the globals.
f98bcec to
7fa8106
Compare
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken |
|
This PR was merged into the repository by commit 840c375. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Grabbing and saving the references to global
setTimeoutandrAFimplementations at a certain point in time can be problematic, espcially in tests. Tests might call something likejasmine.clock().install();andjasmine.clock().uninstall();. If the install happens before we grab the implementation and then the uninstall happens after, our scheduling function will be broken because it would have saved a reference to the jasminesetTimeoutimplementation, which would have since been cleaned up and will throw an error when attempting to accessdelayedFunctionScheduler.There are other scenarios that may apply, not even just for tests, when patches are applied and removed to the globals.