Skip to content

feat(core): Add event delegation library to queue up events and…#55121

Closed
iteriani wants to merge 1 commit intoangular:mainfrom
iteriani:event-dispatch
Closed

feat(core): Add event delegation library to queue up events and…#55121
iteriani wants to merge 1 commit intoangular:mainfrom
iteriani:event-dispatch

Conversation

@iteriani
Copy link
Contributor

… replay them when the application is ready

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • [ X] Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

n/a

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • [ X] No

Other information

@pullapprove pullapprove bot requested a review from atscott March 29, 2024 16:54
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Mar 29, 2024
@jessicajaniuk jessicajaniuk added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: major This PR is targeted for the next major release labels Mar 29, 2024
@ngbot ngbot bot modified the milestone: Backlog Mar 29, 2024
@jessicajaniuk jessicajaniuk requested review from AndrewKushnir and jessicajaniuk and removed request for atscott March 29, 2024 16:56
@iteriani iteriani changed the title feat(primitives): Add event delegation library to queue up events and… feat(core): Add event delegation library to queue up events and… Mar 29, 2024
…y them when the application is ready

This adds the JSAction library from the Wiz framework to core/primitives.
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's likely going to be a lot of follow ups, but for now let's get this merged.

Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 1, 2024
@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit 666d646.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 3, 2024
@pullapprove pullapprove bot added the requires: TGP This PR requires a passing TGP before merging is allowed label May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime detected: feature PR contains a feature commit requires: TGP This PR requires a passing TGP before merging is allowed target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants