Skip to content

fix(core): test cleanup should not throw if Zone is not present#55096

Closed
atscott wants to merge 1 commit intoangular:mainfrom
atscott:dontthrowoncleanup
Closed

fix(core): test cleanup should not throw if Zone is not present#55096
atscott wants to merge 1 commit intoangular:mainfrom
atscott:dontthrowoncleanup

Conversation

@atscott
Copy link
Contributor

@atscott atscott commented Mar 28, 2024

The test hooks should not throw if applications choose not to load ZoneJS.

fixes #48198

@atscott atscott added area: testing Issues related to Angular testing features, such as TestBed area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Mar 28, 2024
@ngbot ngbot bot modified the milestone: Backlog Mar 28, 2024
@atscott atscott requested a review from crisbeto March 28, 2024 17:22
@atscott atscott force-pushed the dontthrowoncleanup branch 2 times, most recently from 324a313 to c21daf8 Compare March 28, 2024 18:03
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Mar 28, 2024
The test hooks should not throw if applications choose not to load ZoneJS.

fixes angular#48198
@atscott atscott force-pushed the dontthrowoncleanup branch from c21daf8 to 2a37275 Compare March 28, 2024 18:42
@atscott atscott closed this in 914e453 Mar 28, 2024
atscott added a commit that referenced this pull request Mar 28, 2024
The test hooks should not throw if applications choose not to load ZoneJS.

fixes #48198

PR Close #55096
@atscott
Copy link
Contributor Author

atscott commented Mar 28, 2024

This PR was merged into the repository by commit 914e453.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime area: testing Issues related to Angular testing features, such as TestBed target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestBed should be zoneless compatible

2 participants