Skip to content

fix(http): include transferCache when cloning HttpRequest#54939

Closed
mlz11 wants to merge 2 commits intoangular:mainfrom
mlz11:include-transferCache-in-http-request-clone-method
Closed

fix(http): include transferCache when cloning HttpRequest#54939
mlz11 wants to merge 2 commits intoangular:mainfrom
mlz11:include-transferCache-in-http-request-clone-method

Conversation

@mlz11
Copy link
Contributor

@mlz11 mlz11 commented Mar 19, 2024 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Fixes #54924.

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from dylhunn March 19, 2024 07:54
@mlz11 mlz11 force-pushed the include-transferCache-in-http-request-clone-method branch from b07fbb4 to f829824 Compare March 19, 2024 07:58
@mlz11 mlz11 mentioned this pull request Mar 19, 2024
Closed
@mlz11 mlz11 force-pushed the include-transferCache-in-http-request-clone-method branch 4 times, most recently from 6b9a647 to 12b50df Compare March 19, 2024 08:24
alan-agius4
alan-agius4 reviewed Mar 19, 2024
View reviewed changes
alan-agius4
alan-agius4 requested changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

Can you please update the commit message scope from common to http?

@alan-agius4 alan-agius4 added area: common/http Issues related to HTTP and HTTP Client target: patch This PR is targeted for the next patch release server: http cache labels Mar 19, 2024
@ngbot ngbot bot added this to the Backlog milestone Mar 19, 2024
@alan-agius4 alan-agius4 added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Mar 19, 2024
@mlz11 mlz11 force-pushed the include-transferCache-in-http-request-clone-method branch from 12b50df to 6f244fc Compare March 19, 2024 10:25
@mlz11
Copy link
Contributor Author

mlz11 commented Mar 19, 2024 •
edited
Loading

Thanks for this.

Can you please update the commit message scope from common to http?

Thanks @alan-agius4 for the quick review 🙂
Of course, done ✅

@mlz11 mlz11 force-pushed the include-transferCache-in-http-request-clone-method branch from 6f244fc to 8a90bb8 Compare March 19, 2024 10:30
alan-agius4
alan-agius4 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution

@alan-agius4 alan-agius4 removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Mar 19, 2024
@alan-agius4
Copy link
Contributor

alan-agius4 commented Mar 19, 2024

Can you please run update the golden files via yarn bazel run //packages/common:common_api.accept?

mlz11 added 2 commits March 19, 2024 10:56
@mlz11
fix(http): include transferCache when cloning HttpRequest
bfb050d 
Fixes a bug where HttpRequest.clone() does not include the transferCache property.

Fixes #54924.
@mlz11
refactor(http): use nullish coalescing operator in HttpRequest.clone()
89e3d25 
Refactor how boolean options are handled in HttpRequest.clone() method by using nullish coalescing operator
@mlz11 mlz11 force-pushed the include-transferCache-in-http-request-clone-method branch from 8a90bb8 to 89e3d25 Compare March 19, 2024 10:56
@mlz11
Copy link
Contributor Author

mlz11 commented Mar 19, 2024 •
edited
Loading

Can you please run update the golden files via yarn bazel run //packages/common:common_api.accept?

Of course, done ✅
I was wondering why tests were failing 😅

kbrilla
kbrilla reviewed Mar 19, 2024
View reviewed changes
packages/common/http/src/request.ts
const responseType = update.responseType || this.responseType;

// Carefully handle the transferCache to differentiate between
// `false` and `undefined` in the update args.
Copy link
Contributor

@kbrilla kbrilla Mar 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now it also handles null so mayby add that to comment : undefined or null here and in other places that were edited. Also why not add move this logic together with withCredentials and reportProgress? becouse now
this comment is duplicated in lines 485 and 495

@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 19, 2024
@mlz11 mlz11 changed the title fix(common): include transferCache when cloning HttpRequest fix(hhtp): include transferCache when cloning HttpRequest Mar 19, 2024
@mlz11 mlz11 changed the title fix(hhtp): include transferCache when cloning HttpRequest fix(http): include transferCache when cloning HttpRequest Mar 19, 2024
@alan-agius4 alan-agius4 removed the request for review from dylhunn March 19, 2024 17:26
@alan-agius4 alan-agius4 requested review from AndrewKushnir and removed request for alan-agius4 March 19, 2024 17:26
alan-agius4
alan-agius4 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 19, 2024
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Mar 19, 2024
dylhunn
dylhunn approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@dylhunn dylhunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@pullapprove pullapprove bot requested a review from jessicajaniuk March 19, 2024 22:03
jessicajaniuk
jessicajaniuk approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

atscott
atscott approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed-for: public-api

@dylhunn
Copy link
Contributor

dylhunn commented Mar 22, 2024

This PR was merged into the repository by commit b80434a.

@dylhunn dylhunn closed this in cf73983 Mar 22, 2024
dylhunn pushed a commit that referenced this pull request Mar 22, 2024
@mlz11 @dylhunn
refactor(http): use nullish coalescing operator in HttpRequest.clone() (
b80434a 
#54939)

Refactor how boolean options are handled in HttpRequest.clone() method by using nullish coalescing operator

PR Close #54939
dylhunn pushed a commit that referenced this pull request Mar 22, 2024
@mlz11 @dylhunn
fix(http): include transferCache when cloning HttpRequest (#54939)
cb433af 
Fixes a bug where HttpRequest.clone() does not include the transferCache property.

Fixes #54924.

PR Close #54939
dylhunn pushed a commit that referenced this pull request Mar 22, 2024
@mlz11 @dylhunn
refactor(http): use nullish coalescing operator in HttpRequest.clone() (
1f7e81a 
#54939)

Refactor how boolean options are handled in HttpRequest.clone() method by using nullish coalescing operator

PR Close #54939
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 22, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@atscott atscott atscott approved these changes

@alan-agius4 alan-agius4 alan-agius4 approved these changes

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

+3 more reviewers

@kbrilla kbrilla kbrilla left review comments

@dylhunn dylhunn dylhunn approved these changes

@jessicajaniuk jessicajaniuk jessicajaniuk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: common/http Issues related to HTTP and HTTP Client server: http cache target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

HttpRequest.clone forgets transferCache

7 participants

@mlz11 @alan-agius4 @dylhunn @atscott @kbrilla @AndrewKushnir @jessicajaniuk