Skip to content

fix(compiler-cli): symbol feature detection for the compiler#54711

Closed
alxhub wants to merge 1 commit intoangular:mainfrom
alxhub:ngtsc/version-detect
Closed

fix(compiler-cli): symbol feature detection for the compiler#54711
alxhub wants to merge 1 commit intoangular:mainfrom
alxhub:ngtsc/version-detect

Conversation

@alxhub
Copy link
Member

@alxhub alxhub commented Mar 5, 2024

Use the actual symbol presence in the .d.ts to detect whether two-way binding to writable signals should be template type-checked.

Use the actual symbol presence in the .d.ts to detect whether two-way
binding to writable signals should be template type-checked.
@alxhub alxhub marked this pull request as ready for review March 19, 2024 22:04
@atscott atscott added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 20, 2024
@atscott
Copy link
Contributor

atscott commented Mar 20, 2024

This PR was merged into the repository by commit 6aff144.

atscott pushed a commit that referenced this pull request Mar 20, 2024
Use the actual symbol presence in the .d.ts to detect whether two-way
binding to writable signals should be template type-checked.

PR Close #54711
@atscott atscott closed this in 6aff144 Mar 20, 2024
atscott added a commit to atscott/angular that referenced this pull request Mar 20, 2024
atscott added a commit that referenced this pull request Mar 20, 2024
this test is failing after #54711

PR Close #54970
atscott added a commit that referenced this pull request Mar 20, 2024
this test is failing after #54711

PR Close #54970
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants