Skip to content

feat(compiler): Enable template pipeline by default.#54571

Closed
dylhunn wants to merge 1 commit intoangular:mainfrom
dylhunn:enable-template-pipeline-3p
Closed

feat(compiler): Enable template pipeline by default.#54571
dylhunn wants to merge 1 commit intoangular:mainfrom
dylhunn:enable-template-pipeline-3p

Conversation

@dylhunn
Copy link
Contributor

@dylhunn dylhunn commented Feb 22, 2024 •
edited
Loading

Template pipeline is now the default template compiler.

A pair of source map tests is failing, related to DI in JIT mode; I will fix and re-enable these during the preview period.

@dylhunn dylhunn added area: compiler Issues related to `ngc`, Angular's template compiler target: minor This PR is targeted for the next minor release compiler: template pipeline labels Feb 22, 2024
@ngbot ngbot bot added this to the Backlog milestone Feb 22, 2024
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Feb 22, 2024
@dylhunn dylhunn force-pushed the enable-template-pipeline-3p branch 2 times, most recently from 01cdf9e to 26242cf Compare February 22, 2024 19:39
mmalerba
mmalerba approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@dylhunn
feat(compiler): Enable template pipeline by default.
09c8aee 
Template pipeline is now the default template compiler.

A pair of source map tests is failing, related to DI in JIT mode; I will fix and re-enable these during the preview period.
@dylhunn dylhunn force-pushed the enable-template-pipeline-3p branch from 26242cf to 09c8aee Compare February 22, 2024 23:32
@dylhunn dylhunn marked this pull request as ready for review February 23, 2024 16:59
@dylhunn dylhunn added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Feb 23, 2024
@dylhunn
Copy link
Contributor Author

dylhunn commented Feb 23, 2024

This PR was merged into the repository by commit 1a6beae.

@dylhunn dylhunn closed this in 1a6beae Feb 23, 2024
@SebastianPodgajny SebastianPodgajny mentioned this pull request Mar 19, 2024
Closed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Mar 25, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mmalerba mmalerba mmalerba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: compiler Issues related to `ngc`, Angular's template compiler compiler: template pipeline detected: feature PR contains a feature commit merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@dylhunn @mmalerba