feat(core): support TypeScript 5.4#54414
Conversation
|
Deployed aio for dd0e4cd to: https://ng-dev-previews-fw--pr-angular-angular-54414-aio-nr1pffhm.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
|
Deployed adev-preview for 0d43aac0cab6d264512f39e11abb3ed90671af2a to: https://ng-dev-previews-fw--pr-angular-angular-54414-adev-prev-q8whc8kk.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
…nums in docs We have a couple of cases now (angular#53753 and angular#54414) where we're forced to redefine enums as object literals. These literals aren't rendered in the best way in the docs so these changes introduce a new `object-literal-as-enum` tag that we can use to mark them so they're treated for documentation purposes.
…nums in docs (#54487) We have a couple of cases now (#53753 and #54414) where we're forced to redefine enums as object literals. These literals aren't rendered in the best way in the docs so these changes introduce a new `object-literal-as-enum` tag that we can use to mark them so they're treated for documentation purposes. PR Close #54487
…nums in docs (#54487) We have a couple of cases now (#53753 and #54414) where we're forced to redefine enums as object literals. These literals aren't rendered in the best way in the docs so these changes introduce a new `object-literal-as-enum` tag that we can use to mark them so they're treated for documentation purposes. PR Close #54487
5a76a3a to
d8ee7cb
Compare
There was a problem hiding this comment.
In theory this is a breaking change as enums allow to use the value as key.
How do we feel about it ?
There was a problem hiding this comment.
There aren't any usages of a backwards lookup in g3 so I'm inclined to say that this isn't common.
|
Passing TGP, except for some pre-existing broken targets. |
devversion
left a comment
There was a problem hiding this comment.
LGTM. Noting the small change that may break downstream (but was discussed) that enum values are no longer possible keys for NumberSymbol.
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Adds support for TypeScript 5.4 to the project.
Fixes that the extraction for `object-literal-as-enum` didn't account for constants initialized to an `as` expression.
|
This PR was merged into the repository by commit 12dc4d0. |
Fixes that the extraction for `object-literal-as-enum` didn't account for constants initialized to an `as` expression. PR Close #54414
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds support for TypeScript 5.4 to the project.