Skip to content

fix(core): show placeholder block on the server with immediate trigger#54394

Closed
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:54385/defer-immediate-server
Closed

fix(core): show placeholder block on the server with immediate trigger#54394
crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto:54385/defer-immediate-server

Conversation

@crisbeto
Copy link
Member

Currently all triggers are set up to show the placeholder block on the server, except for on immediate which is basically a noop. These changes update on immediate to match the rest of the triggers.

Fixes #54385.

Currently all triggers are set up to show the placeholder block on the server, except for `on immediate` which is basically a noop. These changes update `on immediate` to match the rest of the triggers.

Fixes angular#54385.
@crisbeto crisbeto added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release labels Feb 12, 2024
@ngbot ngbot bot modified the milestone: Backlog Feb 12, 2024
@crisbeto crisbeto marked this pull request as ready for review February 12, 2024 13:27
@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 12, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Feb 12, 2024
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 383e093.

AndrewKushnir pushed a commit that referenced this pull request Feb 12, 2024
#54394)

Currently all triggers are set up to show the placeholder block on the server, except for `on immediate` which is basically a noop. These changes update `on immediate` to match the rest of the triggers.

Fixes #54385.

PR Close #54394
AndrewKushnir pushed a commit that referenced this pull request Feb 12, 2024
#54394)

Currently all triggers are set up to show the placeholder block on the server, except for `on immediate` which is basically a noop. These changes update `on immediate` to match the rest of the triggers.

Fixes #54385.

PR Close #54394
atscott pushed a commit to atscott/angular that referenced this pull request Feb 16, 2024
angular#54394)

Currently all triggers are set up to show the placeholder block on the server, except for `on immediate` which is basically a noop. These changes update `on immediate` to match the rest of the triggers.

Fixes angular#54385.

PR Close angular#54394
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@defer doesn't render @placeholder in SSR when @loading present

2 participants