fix(compiler-cli): interpolatedSignalNotInvoked diagnostic for model signals#54338
Closed
cexbrayat wants to merge 1 commit intoangular:mainfrom
Closed
fix(compiler-cli): interpolatedSignalNotInvoked diagnostic for model signals#54338cexbrayat wants to merge 1 commit intoangular:mainfrom
cexbrayat wants to merge 1 commit intoangular:mainfrom
Conversation
crisbeto
approved these changes
Feb 8, 2024
…signals
The new `model()` signal introduces a `ModelSignal` type that needs to be handled by the interpolatedSignalNotInvoked diagnostic to catch issues like:
```
<div>{{ myModel }}</div>
```
b1896dc to
e595bf9
Compare
Contributor
|
This PR was merged into the repository by commit 38b01a3. |
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Feb 8, 2024
…r model signals (angular#54338)" This reverts commit 63a9027.
jessicajaniuk
pushed a commit
that referenced
this pull request
Feb 8, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The new
model()signal introduces aModelSignaltype that needs to be handled by the interpolatedSignalNotInvoked diagnostic to catch issues like:What is the new behavior?
The diagnostic catches the issue
Does this PR introduce a breaking change?
Other information