feat(common): add Netlify image loader#54311
Closed
ascorbic wants to merge 2 commits intoangular:mainfrom
Closed
Conversation
Contributor
There was a problem hiding this comment.
@ascorbic thanks for creating this PR 👍
I've left a couple minor comments, please let me know if you have any questions.
packages/common/src/directives/ng_optimized_image/image_loaders/netlify_loader.ts
Outdated
Show resolved
Hide resolved
packages/common/src/directives/ng_optimized_image/image_loaders/netlify_loader.ts
Outdated
Show resolved
Hide resolved
Add an image loader for Netlify Image CDN. It is slightly different in implementation from existing loaders, because it allows absolute URLs Fixes angular#54303
433cdb2 to
6d60b7c
Compare
Contributor
Author
|
@AndrewKushnir thanks for the review. I've pushed those changes and added a new test for the warn. |
Contributor
AndrewKushnir
approved these changes
Feb 8, 2024
AndrewKushnir
approved these changes
Feb 8, 2024
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
d87df45 to
d5cac8f
Compare
jessicajaniuk
approved these changes
Feb 8, 2024
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
Contributor
|
This PR was merged into the repository by commit 03c3b3e. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an image loader for Netlify Image CDN. It is slightly different in implementation from existing loaders, because it allows absolute URLs.
Fixes #54303
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Other information